* [Qemu-devel] [PATCH] petalogix_ml605_mmu: remove unused variable
@ 2011-03-19 8:45 Blue Swirl
2011-03-19 22:53 ` [Qemu-devel] " Edgar E. Iglesias
0 siblings, 1 reply; 3+ messages in thread
From: Blue Swirl @ 2011-03-19 8:45 UTC (permalink / raw)
To: Edgar E. Iglesias, qemu-devel
Remove a write-only variable, spotted by GCC 4.6.0:
/src/qemu/hw/petalogix_ml605_mmu.c: In function 'petalogix_ml605_init':
/src/qemu/hw/petalogix_ml605_mmu.c:153:11: error: variable 'serial'
set but not used [-Werror=unused-but-set-variable]
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
hw/petalogix_ml605_mmu.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/petalogix_ml605_mmu.c b/hw/petalogix_ml605_mmu.c
index ca0986a..8213902 100644
--- a/hw/petalogix_ml605_mmu.c
+++ b/hw/petalogix_ml605_mmu.c
@@ -150,7 +150,6 @@ petalogix_ml605_init(ram_addr_t ram_size,
ram_addr_t phys_ram;
ram_addr_t phys_flash;
qemu_irq irq[32], *cpu_irq;
- void *serial = NULL;
/* init CPUs */
if (cpu_model == NULL) {
@@ -185,8 +184,8 @@ petalogix_ml605_init(ram_addr_t ram_size,
irq[i] = qdev_get_gpio_in(dev, i);
}
- serial = serial_mm_init(UART16550_BASEADDR + 0x1000, 2, irq[5],
- 115200, serial_hds[0], 1, 0);
+ serial_mm_init(UART16550_BASEADDR + 0x1000, 2, irq[5], 115200,
+ serial_hds[0], 1, 0);
/* 2 timers at irq 2 @ 100 Mhz. */
xilinx_timer_create(TIMER_BASEADDR, irq[2], 2, 100 * 1000000);
--
1.6.2.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: [PATCH] petalogix_ml605_mmu: remove unused variable
2011-03-19 8:45 [Qemu-devel] [PATCH] petalogix_ml605_mmu: remove unused variable Blue Swirl
@ 2011-03-19 22:53 ` Edgar E. Iglesias
2011-03-20 8:08 ` Blue Swirl
0 siblings, 1 reply; 3+ messages in thread
From: Edgar E. Iglesias @ 2011-03-19 22:53 UTC (permalink / raw)
To: Blue Swirl; +Cc: qemu-devel
On Sat, Mar 19, 2011 at 10:45:34AM +0200, Blue Swirl wrote:
> Remove a write-only variable, spotted by GCC 4.6.0:
> /src/qemu/hw/petalogix_ml605_mmu.c: In function 'petalogix_ml605_init':
> /src/qemu/hw/petalogix_ml605_mmu.c:153:11: error: variable 'serial'
> set but not used [-Werror=unused-but-set-variable]
Thanks, feel free to apply.
Cheers
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> hw/petalogix_ml605_mmu.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/petalogix_ml605_mmu.c b/hw/petalogix_ml605_mmu.c
> index ca0986a..8213902 100644
> --- a/hw/petalogix_ml605_mmu.c
> +++ b/hw/petalogix_ml605_mmu.c
> @@ -150,7 +150,6 @@ petalogix_ml605_init(ram_addr_t ram_size,
> ram_addr_t phys_ram;
> ram_addr_t phys_flash;
> qemu_irq irq[32], *cpu_irq;
> - void *serial = NULL;
>
> /* init CPUs */
> if (cpu_model == NULL) {
> @@ -185,8 +184,8 @@ petalogix_ml605_init(ram_addr_t ram_size,
> irq[i] = qdev_get_gpio_in(dev, i);
> }
>
> - serial = serial_mm_init(UART16550_BASEADDR + 0x1000, 2, irq[5],
> - 115200, serial_hds[0], 1, 0);
> + serial_mm_init(UART16550_BASEADDR + 0x1000, 2, irq[5], 115200,
> + serial_hds[0], 1, 0);
>
> /* 2 timers at irq 2 @ 100 Mhz. */
> xilinx_timer_create(TIMER_BASEADDR, irq[2], 2, 100 * 1000000);
> --
> 1.6.2.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: [PATCH] petalogix_ml605_mmu: remove unused variable
2011-03-19 22:53 ` [Qemu-devel] " Edgar E. Iglesias
@ 2011-03-20 8:08 ` Blue Swirl
0 siblings, 0 replies; 3+ messages in thread
From: Blue Swirl @ 2011-03-20 8:08 UTC (permalink / raw)
To: Edgar E. Iglesias; +Cc: qemu-devel
On Sun, Mar 20, 2011 at 12:53 AM, Edgar E. Iglesias
<edgar.iglesias@gmail.com> wrote:
> On Sat, Mar 19, 2011 at 10:45:34AM +0200, Blue Swirl wrote:
>> Remove a write-only variable, spotted by GCC 4.6.0:
>> /src/qemu/hw/petalogix_ml605_mmu.c: In function 'petalogix_ml605_init':
>> /src/qemu/hw/petalogix_ml605_mmu.c:153:11: error: variable 'serial'
>> set but not used [-Werror=unused-but-set-variable]
>
> Thanks, feel free to apply.
OK, applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-20 8:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-19 8:45 [Qemu-devel] [PATCH] petalogix_ml605_mmu: remove unused variable Blue Swirl
2011-03-19 22:53 ` [Qemu-devel] " Edgar E. Iglesias
2011-03-20 8:08 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).