From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37518 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q1522-00018D-Ri
	for qemu-devel@nongnu.org; Sat, 19 Mar 2011 18:54:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Q1521-0003uW-AL
	for qemu-devel@nongnu.org; Sat, 19 Mar 2011 18:54:02 -0400
Received: from mail-ew0-f45.google.com ([209.85.215.45]:43265)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Q1521-0003uC-4W
	for qemu-devel@nongnu.org; Sat, 19 Mar 2011 18:54:01 -0400
Received: by ewy24 with SMTP id 24so1326501ewy.4
	for <qemu-devel@nongnu.org>; Sat, 19 Mar 2011 15:53:59 -0700 (PDT)
Date: Sat, 19 Mar 2011 23:53:55 +0100
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20110319225355.GA24795@laped.lan>
References: <AANLkTin=7j_UNw6cgHeNHjusMebB8NVMLUtzsPQGDsJX@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTin=7j_UNw6cgHeNHjusMebB8NVMLUtzsPQGDsJX@mail.gmail.com>
Subject: [Qemu-devel] Re: [PATCH] petalogix_ml605_mmu: remove unused variable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Sat, Mar 19, 2011 at 10:45:34AM +0200, Blue Swirl wrote:
> Remove a write-only variable, spotted by GCC 4.6.0:
> /src/qemu/hw/petalogix_ml605_mmu.c: In function 'petalogix_ml605_init':
> /src/qemu/hw/petalogix_ml605_mmu.c:153:11: error: variable 'serial'
> set but not used [-Werror=unused-but-set-variable]

Thanks, feel free to apply.

Cheers


> 
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
>  hw/petalogix_ml605_mmu.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/petalogix_ml605_mmu.c b/hw/petalogix_ml605_mmu.c
> index ca0986a..8213902 100644
> --- a/hw/petalogix_ml605_mmu.c
> +++ b/hw/petalogix_ml605_mmu.c
> @@ -150,7 +150,6 @@ petalogix_ml605_init(ram_addr_t ram_size,
>      ram_addr_t phys_ram;
>      ram_addr_t phys_flash;
>      qemu_irq irq[32], *cpu_irq;
> -    void *serial = NULL;
> 
>      /* init CPUs */
>      if (cpu_model == NULL) {
> @@ -185,8 +184,8 @@ petalogix_ml605_init(ram_addr_t ram_size,
>          irq[i] = qdev_get_gpio_in(dev, i);
>      }
> 
> -    serial = serial_mm_init(UART16550_BASEADDR + 0x1000, 2, irq[5],
> -                        115200, serial_hds[0], 1, 0);
> +    serial_mm_init(UART16550_BASEADDR + 0x1000, 2, irq[5], 115200,
> +                   serial_hds[0], 1, 0);
> 
>      /* 2 timers at irq 2 @ 100 Mhz.  */
>      xilinx_timer_create(TIMER_BASEADDR, irq[2], 2, 100 * 1000000);
> -- 
> 1.6.2.4