From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43770 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q1eB4-0006CE-4v
	for qemu-devel@nongnu.org; Mon, 21 Mar 2011 08:25:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1Q1eB2-0007O4-Ee
	for qemu-devel@nongnu.org; Mon, 21 Mar 2011 08:25:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6429)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1Q1eB2-0007Ng-2k
	for qemu-devel@nongnu.org; Mon, 21 Mar 2011 08:25:40 -0400
Date: Mon, 21 Mar 2011 14:24:59 +0200
From: Alon Levy <alevy@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v21 00/11] usb-ccid
Message-ID: <20110321122458.GC9610@playa.tlv.redhat.com>
References: <1300373376-13890-1-git-send-email-alevy@redhat.com>
	<AANLkTi=J9evnCsnVxKWe5dBqPk_C9e8f-GXsdHGa3+GS@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTi=J9evnCsnVxKWe5dBqPk_C9e8f-GXsdHGa3+GS@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Jes.Sorensen@redhat.com, qemu-devel@nongnu.org

On Mon, Mar 21, 2011 at 11:33:57AM +0000, Stefan Hajnoczi wrote:
> On Thu, Mar 17, 2011 at 2:49 PM, Alon Levy <alevy@redhat.com> wrote:
> > This patchset adds three new devices, usb-ccid, ccid-card-passthru and
> > ccid-card-emulated, providing a CCID bus, a simple passthru protocol
> > implementing card requiring a client, and a standalone emulated card.
> >
> > It also introduces a new directory libcaccard with CAC card emulation,
> > CAC is a type of ISO 7816 smart card.
> 
> I just build tested this patchset and got:
> $ make distclean
> $ ./configure --prefix=/usr --target-list=x86_64-softmmu
> --enable-io-thread  --disable-strip
> $ make
>   CC    x86_64-softmmu/../libcacard/vcard_emul_nss.o
> ../libcacard/vcard_emul_nss.c:23:21: fatal error: pk11pub.h: No such
> file or directory
> compilation terminated.
> make[1]: *** [../libcacard/vcard_emul_nss.o] Error 1
> make: *** [subdir-x86_64-softmmu] Error 2
> 
> It seems the smartcard ./configure check needs to be stricter in
> checking for the presence of build dependencies.
> 
> Stefan
> 

Thanks, this should fix it:

diff --git a/Makefile.target b/Makefile.target
index baa5c3f..fef56b4 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -350,7 +350,7 @@ obj-y += $(addprefix $(HWDIR)/, $(hw-obj-y))
 
 endif # CONFIG_SOFTMMU
 
-obj-y += $(addprefix ../libcacard/, $(libcacard-$(CONFIG_SMARTCARD)))
+obj-y += $(addprefix ../libcacard/, $(libcacard-$(CONFIG_SMARTCARD_NSS)))
 
 obj-y += $(addprefix ../, $(trace-obj-y))
 obj-$(CONFIG_GDBSTUB_XML) += gdbstub-xml.o