From: Nathan Froyd <froydnj@codesourcery.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] target-arm/helper.c: For float-int conversion helpers pass ints as ints
Date: Mon, 21 Mar 2011 06:48:08 -0700 [thread overview]
Message-ID: <20110321134808.GG30619@codesourcery.com> (raw)
In-Reply-To: <1300123391-27275-1-git-send-email-peter.maydell@linaro.org>
On Mon, Mar 14, 2011 at 05:23:11PM +0000, Peter Maydell wrote:
> Correct the argument and return types for the float<->int conversion helper
> functions so that integer arguments and return values are declared as
> uint32_t/uint64_t, not float32/float64. This allows us to remove the
> hand-rolled functions which were doing bitwise copies between the types
> via unions.
Reviewed-by: Nathan Froyd <froydnj@codesourcery.com>
I like the direction this patch goes; you aren't by any chance going to
convert the passing/returning of float* to their appropriate int* types
too, are you?
-Nathan
next prev parent reply other threads:[~2011-03-21 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 17:23 [Qemu-devel] [PATCH] target-arm/helper.c: For float-int conversion helpers pass ints as ints Peter Maydell
2011-03-21 13:48 ` Nathan Froyd [this message]
2011-03-21 14:04 ` Peter Maydell
2011-03-21 14:09 ` Nathan Froyd
2011-03-21 14:27 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110321134808.GG30619@codesourcery.com \
--to=froydnj@codesourcery.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).