From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33076 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q1fSv-0004HL-1B for qemu-devel@nongnu.org; Mon, 21 Mar 2011 09:48:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q1fSt-0007Bk-D1 for qemu-devel@nongnu.org; Mon, 21 Mar 2011 09:48:12 -0400 Received: from mail.codesourcery.com ([38.113.113.100]:33939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q1fSt-0007Ax-3W for qemu-devel@nongnu.org; Mon, 21 Mar 2011 09:48:11 -0400 Date: Mon, 21 Mar 2011 06:48:08 -0700 From: Nathan Froyd Subject: Re: [Qemu-devel] [PATCH] target-arm/helper.c: For float-int conversion helpers pass ints as ints Message-ID: <20110321134808.GG30619@codesourcery.com> References: <1300123391-27275-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1300123391-27275-1-git-send-email-peter.maydell@linaro.org> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org On Mon, Mar 14, 2011 at 05:23:11PM +0000, Peter Maydell wrote: > Correct the argument and return types for the float<->int conversion helper > functions so that integer arguments and return values are declared as > uint32_t/uint64_t, not float32/float64. This allows us to remove the > hand-rolled functions which were doing bitwise copies between the types > via unions. Reviewed-by: Nathan Froyd I like the direction this patch goes; you aren't by any chance going to convert the passing/returning of float* to their appropriate int* types too, are you? -Nathan