Re: [Qemu-devel] [PATCH v2 0/3] Allow ipv6 for migration

[Amit Shah <amit.shah@redhat.com>]

On (Fri) 18 Mar 2011 [14:22:47], Juan Quintela wrote:
> Hi
> 
> 
> v2:
> - create socket_set_reuseaddr() to have it different for
>   Windows and everything else (Peter Maydell)
> - use strerror() instead of perror (Peter Maydell)
> - fprintf(): one of them removed, the other one ...
>   it is complicated, would have to return two errors: getaddrinfo one
>   and normal errno.  Not feasible IMHO until we integrate all other users
>   of getaddrinfo() and think of a nice API.
> 
> v1.
> 
> 1st patch moves migration to use getaddrinfo() instead of parse_host_port().
> This allows us to use ipv6 addresses.  As an extra bonus, now we can use
> names from /etc/services.
> 
> Code for net_socket_listen_init() and net_socket_connect_init() was
> almost identical to migration one, so also changed that ones.
> The difference were small based on how error codes were handled.
> After discussing with Anthony, it appears that the right ones are
> the migration ones.
> 
> Tested (the migration code) with:
> - "tcp:foo:4444" ipv4 name
> - "tcp:foo6:4444" ipv6 name
> - "tcp:0:4444"
> - "tcp:foo6:iqobject" (this was an unused entry on my machine /etc/services)
>    iqobject        48619/tcp               # iqobject
> - "tcp::4444": let the kernel make a choice
> 
> Please review.

ACK series.

A couple of whitespace issues; if you're fixing that, you can add my
acked-by to the git log.

		Amit