From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54327 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q2MBi-0006K9-PY
	for qemu-devel@nongnu.org; Wed, 23 Mar 2011 07:25:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Q2MBh-0000xN-54
	for qemu-devel@nongnu.org; Wed, 23 Mar 2011 07:25:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62827)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Q2MBg-0000wp-T8
	for qemu-devel@nongnu.org; Wed, 23 Mar 2011 07:25:17 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2NBPF02024364
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 23 Mar 2011 07:25:15 -0400
Date: Wed, 23 Mar 2011 16:55:13 +0530
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/3] Allow ipv6 for migration
Message-ID: <20110323112513.GB23466@amit-x200.redhat.com>
References: <cover.1300454243.git.quintela@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1300454243.git.quintela@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On (Fri) 18 Mar 2011 [14:22:47], Juan Quintela wrote:
> Hi
> 
> 
> v2:
> - create socket_set_reuseaddr() to have it different for
>   Windows and everything else (Peter Maydell)
> - use strerror() instead of perror (Peter Maydell)
> - fprintf(): one of them removed, the other one ...
>   it is complicated, would have to return two errors: getaddrinfo one
>   and normal errno.  Not feasible IMHO until we integrate all other users
>   of getaddrinfo() and think of a nice API.
> 
> v1.
> 
> 1st patch moves migration to use getaddrinfo() instead of parse_host_port().
> This allows us to use ipv6 addresses.  As an extra bonus, now we can use
> names from /etc/services.
> 
> Code for net_socket_listen_init() and net_socket_connect_init() was
> almost identical to migration one, so also changed that ones.
> The difference were small based on how error codes were handled.
> After discussing with Anthony, it appears that the right ones are
> the migration ones.
> 
> Tested (the migration code) with:
> - "tcp:foo:4444" ipv4 name
> - "tcp:foo6:4444" ipv6 name
> - "tcp:0:4444"
> - "tcp:foo6:iqobject" (this was an unused entry on my machine /etc/services)
>    iqobject        48619/tcp               # iqobject
> - "tcp::4444": let the kernel make a choice
> 
> Please review.

ACK series.

A couple of whitespace issues; if you're fixing that, you can add my
acked-by to the git log.

		Amit