From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=54947 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q2MCN-0006st-Gj for qemu-devel@nongnu.org; Wed, 23 Mar 2011 07:26:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q2MCH-00019v-O9 for qemu-devel@nongnu.org; Wed, 23 Mar 2011 07:25:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q2MCH-00019I-F5 for qemu-devel@nongnu.org; Wed, 23 Mar 2011 07:25:53 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2NBPqCI024564 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 23 Mar 2011 07:25:52 -0400 Date: Wed, 23 Mar 2011 16:55:50 +0530 From: Amit Shah Subject: Re: [Qemu-devel] [PATCH 1/3] create socket_set_reuseaddr() Message-ID: <20110323112550.GC23466@amit-x200.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org On (Fri) 18 Mar 2011 [14:22:48], Juan Quintela wrote: > Windows is different than unix, SO_REUSEADDR is the default value > there. Create one function to do it and change all callers. > > Signed-off-by: Juan Quintela > --- > gdbstub.c | 6 ++---- > migration-tcp.c | 4 +--- > nbd.c | 5 +---- > net/socket.c | 13 ++++--------- > os-posix.c | 1 + Nitpick: this addition in os-posix is a newline, can be dropped. Amit