Re: [Qemu-devel] [PATCH 2/3] Use getaddrinfo for migration

[Amit Shah <amit.shah@redhat.com>]

On (Fri) 18 Mar 2011 [14:22:49], Juan Quintela wrote:
> This allows us to use ipv4/ipv6 for migration addresses.
> Once there, it also uses /etc/services names (it came free).
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  migration-tcp.c |   51 +++++++--------------------
>  net.c           |  106 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  qemu_socket.h   |    3 ++
>  3 files changed, 122 insertions(+), 38 deletions(-)
> 
> diff --git a/migration-tcp.c b/migration-tcp.c
> index 2340b55..2fa496a 100644
> --- a/migration-tcp.c
> +++ b/migration-tcp.c
> @@ -48,8 +48,6 @@ static int tcp_close(FdMigrationState *s)
>      }
>      return 0;
>  }
> -
> -
>  static void tcp_wait_for_connect(void *opaque)

Another nitpick: one newline should be kept.

		Amit