From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55549 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q2MCw-0007L2-A2 for qemu-devel@nongnu.org; Wed, 23 Mar 2011 07:26:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q2MCt-0001PS-RW for qemu-devel@nongnu.org; Wed, 23 Mar 2011 07:26:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1028) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q2MCt-0001PK-Gy for qemu-devel@nongnu.org; Wed, 23 Mar 2011 07:26:31 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2NBQUXF026588 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 23 Mar 2011 07:26:30 -0400 Date: Wed, 23 Mar 2011 16:56:28 +0530 From: Amit Shah Subject: Re: [Qemu-devel] [PATCH 2/3] Use getaddrinfo for migration Message-ID: <20110323112628.GD23466@amit-x200.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org On (Fri) 18 Mar 2011 [14:22:49], Juan Quintela wrote: > This allows us to use ipv4/ipv6 for migration addresses. > Once there, it also uses /etc/services names (it came free). > > Signed-off-by: Juan Quintela > --- > migration-tcp.c | 51 +++++++-------------------- > net.c | 106 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > qemu_socket.h | 3 ++ > 3 files changed, 122 insertions(+), 38 deletions(-) > > diff --git a/migration-tcp.c b/migration-tcp.c > index 2340b55..2fa496a 100644 > --- a/migration-tcp.c > +++ b/migration-tcp.c > @@ -48,8 +48,6 @@ static int tcp_close(FdMigrationState *s) > } > return 0; > } > - > - > static void tcp_wait_for_connect(void *opaque) Another nitpick: one newline should be kept. Amit