From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43955 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q2NaI-0000uI-C4
	for qemu-devel@nongnu.org; Wed, 23 Mar 2011 08:54:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1Q2NaG-0004tn-La
	for qemu-devel@nongnu.org; Wed, 23 Mar 2011 08:54:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20837)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1Q2NaG-0004tZ-As
	for qemu-devel@nongnu.org; Wed, 23 Mar 2011 08:54:44 -0400
Date: Wed, 23 Mar 2011 14:54:04 +0200
From: Alon Levy <alevy@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v22 06/11] libcacard: initial commit
Message-ID: <20110323125404.GC11265@playa.tlv.redhat.com>
References: <1300745246-4701-1-git-send-email-alevy@redhat.com>
	<1300745246-4701-7-git-send-email-alevy@redhat.com>
	<AANLkTik=6A9EMDPcGDpJ6EWmZ7+WwVtgDQO5=Tmo-j67@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <AANLkTik=6A9EMDPcGDpJ6EWmZ7+WwVtgDQO5=Tmo-j67@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org

On Tue, Mar 22, 2011 at 03:25:11PM +0000, Stefan Hajnoczi wrote:
> On Mon, Mar 21, 2011 at 10:07 PM, Alon Levy <alevy@redhat.com> wrote:
> > +# check for libcacard for smartcard support
> > +if test "$smartcard" !=3D "no" ; then
> > + =A0 =A0smartcard=3D"yes"
> > + =A0 =A0smartcard_cflags=3D""
> > + =A0 =A0# TODO - what's the minimal nss version we support?
> > + =A0 =A0if test "$smartcard_nss" !=3D "no"; then
> > + =A0 =A0 =A0 =A0if $pkg_config --atleast-version=3D3.12.8 nss >/dev/=
null 2>&1 ; then
> > + =A0 =A0 =A0 =A0 =A0 =A0smartcard_nss=3D"yes"
> > + =A0 =A0 =A0 =A0 =A0 =A0smartcard_cflags=3D"-I\$(SRC_PATH)/libcacard=
"
> > + =A0 =A0 =A0 =A0 =A0 =A0libcacard_libs=3D$($pkg_config --libs nss 2>=
/dev/null)
> > + =A0 =A0 =A0 =A0 =A0 =A0libcacard_cflags=3D$($pkg_config --cflags ns=
s 2>/dev/null)
> > + =A0 =A0 =A0 =A0 =A0 =A0QEMU_CFLAGS=3D"$QEMU_CFLAGS $smartcard_cflag=
s $libcacard_cflags"
> > + =A0 =A0 =A0 =A0 =A0 =A0LIBS=3D"$libcacard_libs $LIBS"
> > + =A0 =A0 =A0 =A0else
> > + =A0 =A0 =A0 =A0 =A0 =A0if test "$smartcard_nss" =3D=3D "yes"; then
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0feature_not_found "nss"
> > + =A0 =A0 =A0 =A0 =A0 =A0fi
> > + =A0 =A0 =A0 =A0 =A0 =A0smartcard_nss=3D"no"
> > + =A0 =A0 =A0 =A0fi
> > + =A0 =A0fi
> > +fi
> > +if test "$smartcard" =3D=3D "no" ; then
> > + =A0 =A0smartcard_nss=3D"no"
> > +fi
>=20
> '=3D=3D' is not portable, please use '=3D':
>=20
> $ test x =3D=3D y
> test: 1: x: unexpected operator
>=20
> I noticed that this patch introduces error messages here when I run ./c=
onfigure.
>=20
> > +if [ $source_path !=3D `pwd` ]; then
> > + =A0 =A0# out of tree build
> > + =A0 =A0mkdir -p libcacard
> > + =A0 =A0rm -f libcacard/Makefile
> > + =A0 =A0ln -s $source_path/libcacard/Makefile libcacard/Makefile
> > +fi
>=20
> $source_path should have double-quotes around it so this works even
> when the path has spaces.

it is unquoted in the lines above that patch. I'll fix it in the same pat=
ch
in v23.

>=20
> Stefan
>=20