From: Alon Levy <alevy@redhat.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] spicevmc -> chardev: restore guest open / close (v2)
Date: Thu, 24 Mar 2011 12:44:26 +0200 [thread overview]
Message-ID: <20110324104426.GI16926@playa.redhat.com> (raw)
In-Reply-To: <1300961524-6205-1-git-send-email-hdegoede@redhat.com>
On Thu, Mar 24, 2011 at 11:12:01AM +0100, Hans de Goede wrote:
> Hi All,
>
> When we moved from the spicevmc device (which directly implemented a virtio
> serial port) to doing spicevmc as a chardev backend we lost the notification
> of the guest opening / closing the port to spice server. This causes the
> server to not fall back to server mouse mode when the agent inside the
> guest stops / dies (for what ever reason). Which causes the mouse to
> stop working in this scenario. This patch set fixes this regression.
Reviewed-by: Alon Levy <alevy@redhat.com>
>
> Changes since v1:
> -Replace "return qemu_chr_guest_open(vcon->chr);" with just
> "qemu_chr_guest_open(vcon->chr);", since this is a void func. idem for close.
>
> Regards,
>
> Hans
>
next prev parent reply other threads:[~2011-03-24 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 10:12 [Qemu-devel] [PATCH 0/3] spicevmc -> chardev: restore guest open / close (v2) Hans de Goede
2011-03-24 10:12 ` [Qemu-devel] [PATCH 1/3] chardev: Allow frontends to notify backends of guest open / close Hans de Goede
2011-03-24 10:12 ` [Qemu-devel] [PATCH 2/3] virtio-console: notify backend " Hans de Goede
2011-03-24 10:12 ` [Qemu-devel] [PATCH 3/3] spice-chardev: listen to frontend " Hans de Goede
2011-03-24 10:44 ` Alon Levy [this message]
2011-04-25 10:25 ` [Qemu-devel] [PATCH 0/3] spicevmc -> chardev: restore guest open / close (v2) Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110324104426.GI16926@playa.redhat.com \
--to=alevy@redhat.com \
--cc=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).