From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39453 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q30g9-0005n7-2h for qemu-devel@nongnu.org; Fri, 25 Mar 2011 02:39:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q30g7-00054z-VO for qemu-devel@nongnu.org; Fri, 25 Mar 2011 02:39:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q30g7-00054v-Ld for qemu-devel@nongnu.org; Fri, 25 Mar 2011 02:39:23 -0400 Date: Fri, 25 Mar 2011 12:08:51 +0530 From: Amit Shah Message-ID: <20110325063851.GB18889@amit-x200.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [Qemu-devel] Re: [PATCH] virtio-serial: Print out reason for aborting before calling abort() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu list , Juan Quintela On (Fri) 25 Mar 2011 [11:54:02], Amit Shah wrote: > When a port returns an error for not consuming data, we can only handle > the -EAGAIN error type. Any other error isn't handled. Print out a > message indicating this and the error returned. > > Signed-off-by: Amit Shah > --- > hw/virtio-serial-bus.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c > index a82fbe9..0e4ac81 100644 > --- a/hw/virtio-serial-bus.c > +++ b/hw/virtio-serial-bus.c > @@ -155,6 +155,7 @@ static void do_flush_queued_data(VirtIOSerialPort *port, VirtQueue *vq, > buf_size); > if (ret < 0 && ret != -EAGAIN) { > /* We don't handle any other type of errors here */ > + error_report("%s: unexpected return %zd, aborting.\n", ret); Sorry, re-sending. Amit