* [Qemu-devel] [PATCH] virtio-serial: Print out reason for aborting before calling abort()
@ 2011-03-25 6:24 Amit Shah
2011-03-25 6:38 ` [Qemu-devel] " Amit Shah
0 siblings, 1 reply; 2+ messages in thread
From: Amit Shah @ 2011-03-25 6:24 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Amit Shah, qemu list, Juan Quintela
When a port returns an error for not consuming data, we can only handle
the -EAGAIN error type. Any other error isn't handled. Print out a
message indicating this and the error returned.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
hw/virtio-serial-bus.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index a82fbe9..0e4ac81 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio-serial-bus.c
@@ -155,6 +155,7 @@ static void do_flush_queued_data(VirtIOSerialPort *port, VirtQueue *vq,
buf_size);
if (ret < 0 && ret != -EAGAIN) {
/* We don't handle any other type of errors here */
+ error_report("%s: unexpected return %zd, aborting.\n", ret);
abort();
}
if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
--
1.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Qemu-devel] Re: [PATCH] virtio-serial: Print out reason for aborting before calling abort()
2011-03-25 6:24 [Qemu-devel] [PATCH] virtio-serial: Print out reason for aborting before calling abort() Amit Shah
@ 2011-03-25 6:38 ` Amit Shah
0 siblings, 0 replies; 2+ messages in thread
From: Amit Shah @ 2011-03-25 6:38 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu list, Juan Quintela
On (Fri) 25 Mar 2011 [11:54:02], Amit Shah wrote:
> When a port returns an error for not consuming data, we can only handle
> the -EAGAIN error type. Any other error isn't handled. Print out a
> message indicating this and the error returned.
>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> ---
> hw/virtio-serial-bus.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
> index a82fbe9..0e4ac81 100644
> --- a/hw/virtio-serial-bus.c
> +++ b/hw/virtio-serial-bus.c
> @@ -155,6 +155,7 @@ static void do_flush_queued_data(VirtIOSerialPort *port, VirtQueue *vq,
> buf_size);
> if (ret < 0 && ret != -EAGAIN) {
> /* We don't handle any other type of errors here */
> + error_report("%s: unexpected return %zd, aborting.\n", ret);
Sorry, re-sending.
Amit
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-25 6:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-25 6:24 [Qemu-devel] [PATCH] virtio-serial: Print out reason for aborting before calling abort() Amit Shah
2011-03-25 6:38 ` [Qemu-devel] " Amit Shah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).