From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34669 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q4AiE-0006mM-HX
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 07:34:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Q4AiD-0002fE-6R
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 07:34:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13491)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Q4AiC-0002f9-QT
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 07:34:21 -0400
Date: Mon, 28 Mar 2011 13:34:02 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110328113402.GA25451@redhat.com>
References: <cover.1300846473.git.yamahata@valinux.co.jp>
	<20110327145629.GA7913@redhat.com>
	<20110328111956.GF16639@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110328111956.GF16639@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH v5 0/4] piix_pci: optimize irq data path
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org

On Mon, Mar 28, 2011 at 08:19:56PM +0900, Isaku Yamahata wrote:
> On Sun, Mar 27, 2011 at 04:56:29PM +0200, Michael S. Tsirkin wrote:
> > On Wed, Mar 23, 2011 at 11:17:19AM +0900, Isaku Yamahata wrote:
> > > v4 has minor typo. I sent it too early. Here's fixed one.
> > > 
> > > v3 -> v4 Main changes are
> > > - use pirq, pci_intx instead of irq_num in piix_pci.c
> > > - patch 4/4 cleans the code a bit
> > 
> > With this applied e1000 fails to work for me.
> > Command line:
> > 
> > qemu-system-x86_64 -enable-kvm -m 1G -drive
> > if=virtio,file=/home/mst/rhel6.qcow2  -netdev user,id=bar -net
> > nic,netdev=bar,model=e1000,macaddr=52:54:00:12:34:57  -redir
> > tcp:8022::22 -net nic,model=e1000,netdev=foo,macaddr=52:54:00:12:34:56
> > -netdev
> > tap,id=foo,ifname=msttap0,script=/home/mst/ifup,downscript=no
> > -nographic
> > 
> > Could you try that please?
> 
> Does the following patch help?

Seems to help, but I have to ask - how did you test v5?

> If so, I'll prepare v6.
> 
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index c019793..5f0d92f 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -277,7 +277,8 @@ static void piix3_set_irq_pic(PIIX3State *piix3, int pic_irq)
>  {
>      qemu_set_irq(piix3->pic[pic_irq],
>                   !!(piix3->pic_levels &
> -                    ((PIIX_NUM_PIRQS - 1) << (pic_irq * PIIX_NUM_PIRQS))));
> +                    (((1UL << PIIX_NUM_PIRQS) - 1) <<
> +                     (pic_irq * PIIX_NUM_PIRQS))));

I think we should just make it ~0ULL << (pic_irq * PIIX_NUM_PIRQS).
Didn't try this though.

>  }
>  
>  static void piix3_set_irq_level(PIIX3State *piix3, int pirq, int level)
> 
> -- 
> yamahata