From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42611 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q4DR6-00051r-NQ
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 10:28:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1Q4DR4-00055K-Ml
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 10:28:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43687)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1Q4DR4-000553-CY
	for qemu-devel@nongnu.org; Mon, 28 Mar 2011 10:28:50 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2SESnDP021089
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 28 Mar 2011 10:28:49 -0400
Date: Mon, 28 Mar 2011 16:28:45 +0200
From: Alon Levy <alevy@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v23 03/11] usb-ccid: add CCID bus
Message-ID: <20110328142845.GC2741@playa.redhat.com>
References: <1300886393-2799-1-git-send-email-alevy@redhat.com>
	<1300886393-2799-4-git-send-email-alevy@redhat.com>
	<4D90787D.3090700@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D90787D.3090700@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, Mar 28, 2011 at 02:01:01PM +0200, Jes Sorensen wrote:
> On 03/23/11 14:19, Alon Levy wrote:
> > A CCID device is a smart card reader. It is a USB device, defined at [1].
> > This patch introduces the usb-ccid device that is a ccid bus. Next patches will
> > introduce two card types to use it, a passthru card and an emulated card.
> > 
> >  [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_Rev110.
> > 
> > Signed-off-by: Alon Levy <alevy@redhat.com>
> 
> This looks ok to me now - I noticed that the comments in the header file
> refers to u8/u16/u32 for types, even though the code uses
> uint{8,16,32}_t, but I don't think that warrants a fix.

You mean the comments in hw/usb-ccid.c in the descriptor? that's just shorter.

> 
> If the comment goes in, please fix the spelling of my name.
> 
> Reviewed-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>