From: Amit Shah <amit.shah@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kwolf@redhat.com, gleb@redhat.com,
Jes Sorensen <Jes.Sorensen@redhat.com>,
Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, armbru@redhat.com,
Christoph Hellwig <hch@infradead.org>,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] virtio: don't exit on guest errors
Date: Tue, 29 Mar 2011 16:03:19 +0530 [thread overview]
Message-ID: <20110329103319.GA5968@amit-x200.redhat.com> (raw)
In-Reply-To: <4e66df1d082db84937a97ef18595fafcc3d68e55.1301346785.git.mst@redhat.com>
On (Mon) 28 Mar 2011 [23:14:16], Michael S. Tsirkin wrote:
> When guest does something illegal, such as
> programming invalid index values in the virtio
> device, qemu currently tends to crash.
>
> With virtio, a better idea is to log an error,
> and set status to FAIL which stops the device.
>
> Add an API to do this, and fix core, blk and serial
> to use it on error.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/virtio-blk.c | 12 +++++--
> hw/virtio-serial-bus.c | 13 +++++--
> hw/virtio.c | 79 +++++++++++++++++++++++++++++++-----------------
> hw/virtio.h | 7 +++-
> 4 files changed, 73 insertions(+), 38 deletions(-)
ACK
Amit
next prev parent reply other threads:[~2011-03-29 10:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 21:13 [Qemu-devel] [PATCH 0/3] virtio and vhost error handling Michael S. Tsirkin
2011-03-28 21:14 ` [Qemu-devel] [PATCH 1/3] virtio: don't exit on guest errors Michael S. Tsirkin
2011-03-29 10:33 ` Amit Shah [this message]
2011-03-28 21:14 ` [Qemu-devel] [PATCH 2/3] vhost: don't exit on memory errors Michael S. Tsirkin
2011-03-28 21:14 ` [Qemu-devel] [PATCH 3/3] vhost: roll our own cpu map variant Michael S. Tsirkin
2011-03-29 10:53 ` Stefan Hajnoczi
2011-03-30 16:09 ` Michael S. Tsirkin
2011-03-30 16:26 ` Stefan Hajnoczi
2011-03-30 16:59 ` Michael S. Tsirkin
2011-03-30 17:59 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110329103319.GA5968@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=gleb@redhat.com \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).