* [Qemu-devel] [PATCH] register signal handler after initializing SDL.
@ 2011-03-31 9:27 Gleb Natapov
2011-04-03 22:26 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Gleb Natapov @ 2011-03-31 9:27 UTC (permalink / raw)
To: qemu-devel
SDL library initialization mangles signal handlers, so QEMU should
register them after initializing SDL. This was the case before and code
even have a comment about that. Fix it to be so again.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
diff --git a/vl.c b/vl.c
index 192a240..93aaccf 100644
--- a/vl.c
+++ b/vl.c
@@ -3148,9 +3148,6 @@ int main(int argc, char **argv, char **envp)
cpu_synchronize_all_post_init();
- /* must be after terminal init, SDL library changes signal handlers */
- os_setup_signal_handling();
-
set_numa_modes();
current_machine = machine;
@@ -3206,6 +3203,9 @@ int main(int argc, char **argv, char **envp)
break;
}
+ /* must be after terminal init, SDL library changes signal handlers */
+ os_setup_signal_handling();
+
#ifdef CONFIG_VNC
/* init remote displays */
if (vnc_display) {
--
Gleb.
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] register signal handler after initializing SDL.
2011-03-31 9:27 [Qemu-devel] [PATCH] register signal handler after initializing SDL Gleb Natapov
@ 2011-04-03 22:26 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2011-04-03 22:26 UTC (permalink / raw)
To: Gleb Natapov; +Cc: qemu-devel
On Thu, Mar 31, 2011 at 11:27:23AM +0200, Gleb Natapov wrote:
> SDL library initialization mangles signal handlers, so QEMU should
> register them after initializing SDL. This was the case before and code
> even have a comment about that. Fix it to be so again.
>
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Thanks, applied.
> diff --git a/vl.c b/vl.c
> index 192a240..93aaccf 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3148,9 +3148,6 @@ int main(int argc, char **argv, char **envp)
>
> cpu_synchronize_all_post_init();
>
> - /* must be after terminal init, SDL library changes signal handlers */
> - os_setup_signal_handling();
> -
> set_numa_modes();
>
> current_machine = machine;
> @@ -3206,6 +3203,9 @@ int main(int argc, char **argv, char **envp)
> break;
> }
>
> + /* must be after terminal init, SDL library changes signal handlers */
> + os_setup_signal_handling();
> +
> #ifdef CONFIG_VNC
> /* init remote displays */
> if (vnc_display) {
> --
> Gleb.
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-03 22:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-31 9:27 [Qemu-devel] [PATCH] register signal handler after initializing SDL Gleb Natapov
2011-04-03 22:26 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).