From: Aurelien Jarno <aurelien@aurel32.net>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] fix build errors when we enable acpi_piix4 debug
Date: Fri, 1 Apr 2011 22:08:23 +0200 [thread overview]
Message-ID: <20110401200823.GA31037@volta.aurel32.net> (raw)
In-Reply-To: <4D6B06E9.7080303@cn.fujitsu.com>
On Mon, Feb 28, 2011 at 10:22:33AM +0800, Wen Congyang wrote:
> I enable acpi_piix4 debug, and got the following build errors:
> # make
> CC libhw64/acpi_piix4.o
> cc1: warnings being treated as errors
> /home/wency/source/qemu/hw/acpi_piix4.c: In function ‘pm_ioport_write’:
> /home/wency/source/qemu/hw/acpi_piix4.c:193: error: format ‘%04x’ expects type ‘unsigned int’, but argument 2 has type ‘uint64_t’
> /home/wency/source/qemu/hw/acpi_piix4.c:193: error: format ‘%04x’ expects type ‘unsigned int’, but argument 3 has type ‘uint64_t’
> /home/wency/source/qemu/hw/acpi_piix4.c: In function ‘pm_ioport_read’:
> /home/wency/source/qemu/hw/acpi_piix4.c:219: error: format ‘%04x’ expects type ‘unsigned int’, but argument 2 has type ‘uint64_t’
> make[1]: *** [acpi_piix4.o] Error 1
> make: *** [subdir-libhw64] Error 2
>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>
> ---
> hw/acpi_piix4.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
Thanks, applied.
> diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
> index 5bbc2b5..b5a2762 100644
> --- a/hw/acpi_piix4.c
> +++ b/hw/acpi_piix4.c
> @@ -190,7 +190,8 @@ static void pm_ioport_write(IORange *ioport, uint64_t addr, unsigned width,
> default:
> break;
> }
> - PIIX4_DPRINTF("PM writew port=0x%04x val=0x%04x\n", addr, val);
> + PIIX4_DPRINTF("PM writew port=0x%04x val=0x%04x\n", (unsigned int)addr,
> + (unsigned int)val);
> }
>
> static void pm_ioport_read(IORange *ioport, uint64_t addr, unsigned width,
> @@ -216,7 +217,7 @@ static void pm_ioport_read(IORange *ioport, uint64_t addr, unsigned width,
> val = 0;
> break;
> }
> - PIIX4_DPRINTF("PM readw port=0x%04x val=0x%04x\n", addr, val);
> + PIIX4_DPRINTF("PM readw port=0x%04x val=0x%04x\n", (unsigned int)addr, val);
> *data = val;
> }
>
> --
> 1.7.1
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2011-04-01 20:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 2:22 [Qemu-devel] [PATCH] fix build errors when we enable acpi_piix4 debug Wen Congyang
2011-04-01 20:08 ` Aurelien Jarno [this message]
2011-04-01 23:41 ` Isaku Yamahata
2011-04-03 14:58 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110401200823.GA31037@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).