From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59564 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q5l3H-000400-QT for qemu-devel@nongnu.org; Fri, 01 Apr 2011 16:34:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q5l3G-0007nU-NH for qemu-devel@nongnu.org; Fri, 01 Apr 2011 16:34:39 -0400 Received: from hall.aurel32.net ([88.191.126.93]:60658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q5l3G-0007nQ-Cj for qemu-devel@nongnu.org; Fri, 01 Apr 2011 16:34:38 -0400 Date: Fri, 1 Apr 2011 22:34:36 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 0/2] ARM: fix VLD of one element to all lanes Message-ID: <20110401203436.GF31037@volta.aurel32.net> References: <1300206412-29014-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1300206412-29014-1-git-send-email-peter.maydell@linaro.org> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org On Tue, Mar 15, 2011 at 04:26:50PM +0000, Peter Maydell wrote: > This patchset fixes various bugs in the implementation of the Neon > instructions loading a single element to all lanes. > > The primary bug is that VLD1's "single element to all lanes" form differs > from those for VLD2, VLD3 and VLD4 in that bit 5 indicates whether the > loaded element should be written to one or two Dregs, rather than being a > register stride. (This is the issue addressed by Meego commit 6f3b4ee, > although my choice of fix is different.) > > We were also incorrectly UNDEFfing VLD4.32 with 16 byte alignment > specifier, failing to UNDEF for invalid size and alignment combinations, > and leaking a TCG temporary on the UNDEF code paths. > > Tested via the usual random instruction set testing, and also with the > valgrind 'neon64' test case. > > Peter Maydell (2): > target-arm: Fix VLD of single element to all lanes > target-arm: Don't leak TCG temp for UNDEFs in Neon load/store space > > target-arm/translate.c | 92 ++++++++++++++++++++++++++++++++++-------------- > 1 files changed, 65 insertions(+), 27 deletions(-) > Thanks, both applied. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net