From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53645 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q5nyB-00006s-9O
	for qemu-devel@nongnu.org; Fri, 01 Apr 2011 19:41:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yamahata@valinux.co.jp>) id 1Q5ny9-0003gE-FN
	for qemu-devel@nongnu.org; Fri, 01 Apr 2011 19:41:35 -0400
Received: from mail.valinux.co.jp ([210.128.90.3]:57305)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yamahata@valinux.co.jp>) id 1Q5ny8-0003f8-Oa
	for qemu-devel@nongnu.org; Fri, 01 Apr 2011 19:41:33 -0400
Date: Sat, 2 Apr 2011 08:41:28 +0900
From: Isaku Yamahata <yamahata@valinux.co.jp>
Subject: Re: [Qemu-devel] [PATCH] fix build errors when we enable
	acpi_piix4 debug
Message-ID: <20110401234128.GE8401@valinux.co.jp>
References: <4D6B06E9.7080303@cn.fujitsu.com>
	<20110401200823.GA31037@volta.aurel32.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-2022-jp
Content-Disposition: inline
In-Reply-To: <20110401200823.GA31037@volta.aurel32.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel <qemu-devel@nongnu.org>

Sorry for late comment after the commit.
PRIx64 shouldn't be used instead of cast?

On Fri, Apr 01, 2011 at 10:08:23PM +0200, Aurelien Jarno wrote:
> On Mon, Feb 28, 2011 at 10:22:33AM +0800, Wen Congyang wrote:
> > I enable acpi_piix4 debug, and got the following build errors:
> > # make
> >   CC    libhw64/acpi_piix4.o
> > cc1: warnings being treated as errors
> > /home/wency/source/qemu/hw/acpi_piix4.c: In function ‘pm_ioport_write’:
> > /home/wency/source/qemu/hw/acpi_piix4.c:193: error: format ‘%04x’ expects type ‘unsigned int’, but argument 2 has type ‘uint64_t’
> > /home/wency/source/qemu/hw/acpi_piix4.c:193: error: format ‘%04x’ expects type ‘unsigned int’, but argument 3 has type ‘uint64_t’
> > /home/wency/source/qemu/hw/acpi_piix4.c: In function ‘pm_ioport_read’:
> > /home/wency/source/qemu/hw/acpi_piix4.c:219: error: format ‘%04x’ expects type ‘unsigned int’, but argument 2 has type ‘uint64_t’
> > make[1]: *** [acpi_piix4.o] Error 1
> > make: *** [subdir-libhw64] Error 2
> > 
> > Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> > 
> > ---
> >  hw/acpi_piix4.c |    5 +++--
> >  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> Thanks, applied.
> 
> > diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
> > index 5bbc2b5..b5a2762 100644
> > --- a/hw/acpi_piix4.c
> > +++ b/hw/acpi_piix4.c
> > @@ -190,7 +190,8 @@ static void pm_ioport_write(IORange *ioport, uint64_t addr, unsigned width,
> >      default:
> >          break;
> >      }
> > -    PIIX4_DPRINTF("PM writew port=0x%04x val=0x%04x\n", addr, val);
> > +    PIIX4_DPRINTF("PM writew port=0x%04x val=0x%04x\n", (unsigned int)addr,
> > +                  (unsigned int)val);
> >  }
> >  
> >  static void pm_ioport_read(IORange *ioport, uint64_t addr, unsigned width,
> > @@ -216,7 +217,7 @@ static void pm_ioport_read(IORange *ioport, uint64_t addr, unsigned width,
> >          val = 0;
> >          break;
> >      }
> > -    PIIX4_DPRINTF("PM readw port=0x%04x val=0x%04x\n", addr, val);
> > +    PIIX4_DPRINTF("PM readw port=0x%04x val=0x%04x\n", (unsigned int)addr, val);
> >      *data = val;
> >  }
> >  
> > -- 
> > 1.7.1
> > 
> > 
> 
> -- 
> Aurelien Jarno                          GPG: 1024D/F1BCDB73
> aurelien@aurel32.net                 http://www.aurel32.net
> 

-- 
yamahata