qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alon Levy <alevy@redhat.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] w32: Fix compilation (wrong include file)
Date: Sun, 3 Apr 2011 10:39:15 +0300	[thread overview]
Message-ID: <20110403073915.GH4047@playa.redhat.com> (raw)
In-Reply-To: <1301813735-3506-1-git-send-email-weil@mail.berlios.de>

On Sun, Apr 03, 2011 at 08:55:35AM +0200, Stefan Weil wrote:
> arpa/inet.h is not available for w32, so commit
> edbb21363fbfe40e050f583df921484cbc31c79d breaks
> w32 compilations.
> 
> This is fixed by using qemu_socket.h.
> 

Thanks, missed that.

Reviewed-by: Alon Levy <alevy@redhat.com>

> Cc: Alon Levy <alevy@redhat.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  hw/ccid-card-passthru.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/ccid-card-passthru.c b/hw/ccid-card-passthru.c
> index 8506fed..28eb9d1 100644
> --- a/hw/ccid-card-passthru.c
> +++ b/hw/ccid-card-passthru.c
> @@ -8,9 +8,8 @@
>   * See the COPYING file in the top-level directory.
>   */
>  
> -#include <arpa/inet.h>
> -
>  #include "qemu-char.h"
> +#include "qemu_socket.h"
>  #include "monitor.h"
>  #include "hw/ccid.h"
>  #include "libcacard/vscard_common.h"
> -- 
> 1.7.0.4
> 

  reply	other threads:[~2011-04-03  7:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-03  6:55 [Qemu-devel] [PATCH] w32: Fix compilation (wrong include file) Stefan Weil
2011-04-03  7:39 ` Alon Levy [this message]
2011-04-03 22:30 ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110403073915.GH4047@playa.redhat.com \
    --to=alevy@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=weil@mail.berlios.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).