* [Qemu-devel] [PATCH] w32: Fix compilation (wrong include file)
@ 2011-04-03 6:55 Stefan Weil
2011-04-03 7:39 ` [Qemu-devel] " Alon Levy
2011-04-03 22:30 ` [Qemu-devel] " Aurelien Jarno
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Weil @ 2011-04-03 6:55 UTC (permalink / raw)
To: Blue Swirl; +Cc: Alon Levy, QEMU Developers
arpa/inet.h is not available for w32, so commit
edbb21363fbfe40e050f583df921484cbc31c79d breaks
w32 compilations.
This is fixed by using qemu_socket.h.
Cc: Alon Levy <alevy@redhat.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
hw/ccid-card-passthru.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/ccid-card-passthru.c b/hw/ccid-card-passthru.c
index 8506fed..28eb9d1 100644
--- a/hw/ccid-card-passthru.c
+++ b/hw/ccid-card-passthru.c
@@ -8,9 +8,8 @@
* See the COPYING file in the top-level directory.
*/
-#include <arpa/inet.h>
-
#include "qemu-char.h"
+#include "qemu_socket.h"
#include "monitor.h"
#include "hw/ccid.h"
#include "libcacard/vscard_common.h"
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: [PATCH] w32: Fix compilation (wrong include file)
2011-04-03 6:55 [Qemu-devel] [PATCH] w32: Fix compilation (wrong include file) Stefan Weil
@ 2011-04-03 7:39 ` Alon Levy
2011-04-03 22:30 ` [Qemu-devel] " Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Alon Levy @ 2011-04-03 7:39 UTC (permalink / raw)
To: Stefan Weil; +Cc: Blue Swirl, QEMU Developers
On Sun, Apr 03, 2011 at 08:55:35AM +0200, Stefan Weil wrote:
> arpa/inet.h is not available for w32, so commit
> edbb21363fbfe40e050f583df921484cbc31c79d breaks
> w32 compilations.
>
> This is fixed by using qemu_socket.h.
>
Thanks, missed that.
Reviewed-by: Alon Levy <alevy@redhat.com>
> Cc: Alon Levy <alevy@redhat.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> hw/ccid-card-passthru.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ccid-card-passthru.c b/hw/ccid-card-passthru.c
> index 8506fed..28eb9d1 100644
> --- a/hw/ccid-card-passthru.c
> +++ b/hw/ccid-card-passthru.c
> @@ -8,9 +8,8 @@
> * See the COPYING file in the top-level directory.
> */
>
> -#include <arpa/inet.h>
> -
> #include "qemu-char.h"
> +#include "qemu_socket.h"
> #include "monitor.h"
> #include "hw/ccid.h"
> #include "libcacard/vscard_common.h"
> --
> 1.7.0.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] w32: Fix compilation (wrong include file)
2011-04-03 6:55 [Qemu-devel] [PATCH] w32: Fix compilation (wrong include file) Stefan Weil
2011-04-03 7:39 ` [Qemu-devel] " Alon Levy
@ 2011-04-03 22:30 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2011-04-03 22:30 UTC (permalink / raw)
To: Stefan Weil; +Cc: Blue Swirl, Alon Levy, QEMU Developers
On Sun, Apr 03, 2011 at 08:55:35AM +0200, Stefan Weil wrote:
> arpa/inet.h is not available for w32, so commit
> edbb21363fbfe40e050f583df921484cbc31c79d breaks
> w32 compilations.
>
> This is fixed by using qemu_socket.h.
>
> Cc: Alon Levy <alevy@redhat.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> hw/ccid-card-passthru.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
Thanks, applied.
> diff --git a/hw/ccid-card-passthru.c b/hw/ccid-card-passthru.c
> index 8506fed..28eb9d1 100644
> --- a/hw/ccid-card-passthru.c
> +++ b/hw/ccid-card-passthru.c
> @@ -8,9 +8,8 @@
> * See the COPYING file in the top-level directory.
> */
>
> -#include <arpa/inet.h>
> -
> #include "qemu-char.h"
> +#include "qemu_socket.h"
> #include "monitor.h"
> #include "hw/ccid.h"
> #include "libcacard/vscard_common.h"
> --
> 1.7.0.4
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-03 22:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-03 6:55 [Qemu-devel] [PATCH] w32: Fix compilation (wrong include file) Stefan Weil
2011-04-03 7:39 ` [Qemu-devel] " Alon Levy
2011-04-03 22:30 ` [Qemu-devel] " Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).