From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46348 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6KW9-00065F-V5 for qemu-devel@nongnu.org; Sun, 03 Apr 2011 06:26:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6KW4-0007lL-M8 for qemu-devel@nongnu.org; Sun, 03 Apr 2011 06:26:49 -0400 Received: from mail.valinux.co.jp ([210.128.90.3]:34883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6KW4-0007ka-DI for qemu-devel@nongnu.org; Sun, 03 Apr 2011 06:26:44 -0400 Date: Sun, 3 Apr 2011 19:26:39 +0900 From: Isaku Yamahata Subject: Re: [Qemu-devel] [PATCH] Register only one qbus_reset_all_fn() for system bus Message-ID: <20110403102639.GC11748@valinux.co.jp> References: <1298243333-23799-1-git-send-email-dbaryshkov@gmail.com> <20110401195746.GB24630@volta.aurel32.net> <20110402001203.GA11748@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dmitry Eremin-Solenikov Cc: qemu-devel@nongnu.org, Aurelien Jarno On Sat, Apr 02, 2011 at 06:47:37PM +0400, Dmitry Eremin-Solenikov wrote: > On 4/2/11, Isaku Yamahata wrote: > >> Have you verified that all bus devices have been qdevified since this > >> code has been added? I wouldn't bet it is the case. > > > > I think his analysis is valid. So how about the following patch. > > Could you please point me to an example of devices for which this check is > required. Although I don't have any example, I bet to not change the reset order. If you check all the devices, it's good. -- yamahata