From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44386 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6Lfm-0002hY-1F for qemu-devel@nongnu.org; Sun, 03 Apr 2011 07:40:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6Lfc-0005Lh-3i for qemu-devel@nongnu.org; Sun, 03 Apr 2011 07:40:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6Lfb-0005LT-PQ for qemu-devel@nongnu.org; Sun, 03 Apr 2011 07:40:40 -0400 Date: Sun, 3 Apr 2011 14:40:15 +0300 From: "Michael S. Tsirkin" Message-ID: <20110403114014.GA13659@redhat.com> References: <1301603611-7964-1-git-send-email-weil@mail.berlios.de> <1301603611-7964-3-git-send-email-weil@mail.berlios.de> <20110331215253.GD27264@redhat.com> <4D9610F4.6040704@mail.berlios.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D9610F4.6040704@mail.berlios.de> Subject: [Qemu-devel] Re: [PATCH 2/9] eepro100: Fix endianness issues List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Developers On Fri, Apr 01, 2011 at 07:52:52PM +0200, Stefan Weil wrote: > [snip] > > Thank you for your review, especially for the hints at lduw_phys > and potential alignment issues. I'll apply them to a new version > of this patch. > > There was already a function without prefix (stl_le_phys), > and the new ones belong to the same "family". There is nothing > e100 specific in them, so they might be added to qemu-common.h > as well. That was (and is) the reason why I did not add a prefix. Yes but they don't seem to do much useful, IMO open-coding will be clearer, they are unlikely to be generally useful. But if you like to keep them pls add a eepro100 prefix. -- MST