From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] tests/cris: Fix some errors and potential crashes
Date: Sun, 3 Apr 2011 21:57:46 +0200 [thread overview]
Message-ID: <20110403195746.GA25253@laped.lan> (raw)
In-Reply-To: <1301859396-9701-1-git-send-email-weil@mail.berlios.de>
On Sun, Apr 03, 2011 at 09:36:36PM +0200, Stefan Weil wrote:
> These errors were reported by cppcheck:
>
> tests/cris/check_openpf1.c:30: error:
> Mismatching allocation and deallocation: f
>
> tests/cris/check_openpf2.c:13: error:
> Mismatching allocation and deallocation: f
>
> tests/cris/check_stat3.c:16: error:
> Buffer overrun possible for long cmd-line args
>
> tests/cris/check_stat4.c:18: error:
> Buffer overrun possible for long cmd-line args
>
> The first two are obvious coding errors (fopen needs fclose, not close).
>
> The last two may seem less important (nobody will start test code
> with an argument of more than 1022 characters which raises a buffer
> overrun). Fixing them nevertheless helps with static code checks
> like those done by cppcheck.
Thanks, I've applied this.
Cheers
prev parent reply other threads:[~2011-04-03 19:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-03 19:36 [Qemu-devel] [PATCH] tests/cris: Fix some errors and potential crashes Stefan Weil
2011-04-03 19:57 ` Edgar E. Iglesias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110403195746.GA25253@laped.lan \
--to=edgar.iglesias@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).