From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44114 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q6Vkr-0001UH-L3
	for qemu-devel@nongnu.org; Sun, 03 Apr 2011 18:26:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Q6Vkq-0008GE-IY
	for qemu-devel@nongnu.org; Sun, 03 Apr 2011 18:26:45 -0400
Received: from hall.aurel32.net ([88.191.126.93]:43375)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Q6Vkq-0008G7-Cm
	for qemu-devel@nongnu.org; Sun, 03 Apr 2011 18:26:44 -0400
Date: Mon, 4 Apr 2011 00:26:42 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] register signal handler after
	initializing SDL.
Message-ID: <20110403222642.GF13927@volta.aurel32.net>
References: <20110331092723.GJ7766@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <20110331092723.GJ7766@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, Mar 31, 2011 at 11:27:23AM +0200, Gleb Natapov wrote:
> SDL library initialization mangles signal handlers, so QEMU should
> register them after initializing SDL. This was the case before and code
> even have a comment about that. Fix it to be so again.
> 
> Signed-off-by: Gleb Natapov <gleb@redhat.com> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Thanks, applied.


> diff --git a/vl.c b/vl.c
> index 192a240..93aaccf 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3148,9 +3148,6 @@ int main(int argc, char **argv, char **envp)
>  
>      cpu_synchronize_all_post_init();
>  
> -    /* must be after terminal init, SDL library changes signal handlers */
> -    os_setup_signal_handling();
> -
>      set_numa_modes();
>  
>      current_machine = machine;
> @@ -3206,6 +3203,9 @@ int main(int argc, char **argv, char **envp)
>          break;
>      }
>  
> +    /* must be after terminal init, SDL library changes signal handlers */
> +    os_setup_signal_handling();
> +
>  #ifdef CONFIG_VNC
>      /* init remote displays */
>      if (vnc_display) {
> --
> 			Gleb.
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net