Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

[Luiz Capitulino <lcapitulino@redhat.com>]

On Mon, 04 Apr 2011 08:09:29 -0500
Anthony Liguori <anthony@codemonkey.ws> wrote:

> On 04/04/2011 07:19 AM, Markus Armbruster wrote:
> > [Note cc: Anthony]
> >
> > "Daniel P. Berrange"<berrange@redhat.com>  writes:
> >
> >> On Mon, Mar 07, 2011 at 05:46:28PM +0800, Lai Jiangshan wrote:
> >>> From: Lai Jiangshan<laijs@cn.fujitsu.com>
> >>> Date: Mon, 7 Mar 2011 17:05:15 +0800
> >>> Subject: [PATCH 2/2] qemu,qmp: add inject-nmi qmp command
> >>>
> >>> inject-nmi command injects an NMI on all CPUs of guest.
> >>> It is only supported for x86 guest currently, it will
> >>> returns "Unsupported" error for non-x86 guest.
> >>>
> >>> ---
> >>>   hmp-commands.hx |    2 +-
> >>>   monitor.c       |   18 +++++++++++++++++-
> >>>   qmp-commands.hx |   29 +++++++++++++++++++++++++++++
> >>>   3 files changed, 47 insertions(+), 2 deletions(-)
> >> Does anyone have any feedback on this addition, or are all new
> >> QMP patch proposals blocked pending Anthony's QAPI work ?
> > That would be bad.  Anthony, what's holding this back?
> 
> It doesn't pass checkpath.pl.
> 
> But I'd also expect this to come through Luiz's QMP tree.

I had this ready in my tree some time ago, but you commented on that
version asking for errors descriptions and other things, so I didn't
push it.

But we have to set expectations here. My tree will eventually die,
specially wrt new interfaces where I expect you to jump in ASAP. First
because you have to be sure a new interface "conforms" to QAPI, and
second (and more importantly) because it's time to pass this on to
someone else (preferably you).