From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=54299 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6jvA-00083T-Fu for qemu-devel@nongnu.org; Mon, 04 Apr 2011 09:34:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6jv8-0002vi-Vg for qemu-devel@nongnu.org; Mon, 04 Apr 2011 09:34:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6jv8-0002vY-HZ for qemu-devel@nongnu.org; Mon, 04 Apr 2011 09:34:18 -0400 Date: Mon, 4 Apr 2011 10:34:07 -0300 From: Luiz Capitulino Subject: Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command Message-ID: <20110404103407.1d21d8e5@doriath> In-Reply-To: <4D99C309.6060905@codemonkey.ws> References: <4D74A8C9.2020408@cn.fujitsu.com> <4D74A974.6090509@cn.fujitsu.com> <20110404105949.GA30324@redhat.com> <4D99C309.6060905@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Lai Jiangshan , Lai Jiangshan , kvm@vger.kernel.org, qemu-devel@nongnu.org, Markus Armbruster , Avi@gnu.org, Kivity On Mon, 04 Apr 2011 08:09:29 -0500 Anthony Liguori wrote: > On 04/04/2011 07:19 AM, Markus Armbruster wrote: > > [Note cc: Anthony] > > > > "Daniel P. Berrange" writes: > > > >> On Mon, Mar 07, 2011 at 05:46:28PM +0800, Lai Jiangshan wrote: > >>> From: Lai Jiangshan > >>> Date: Mon, 7 Mar 2011 17:05:15 +0800 > >>> Subject: [PATCH 2/2] qemu,qmp: add inject-nmi qmp command > >>> > >>> inject-nmi command injects an NMI on all CPUs of guest. > >>> It is only supported for x86 guest currently, it will > >>> returns "Unsupported" error for non-x86 guest. > >>> > >>> --- > >>> hmp-commands.hx | 2 +- > >>> monitor.c | 18 +++++++++++++++++- > >>> qmp-commands.hx | 29 +++++++++++++++++++++++++++++ > >>> 3 files changed, 47 insertions(+), 2 deletions(-) > >> Does anyone have any feedback on this addition, or are all new > >> QMP patch proposals blocked pending Anthony's QAPI work ? > > That would be bad. Anthony, what's holding this back? > > It doesn't pass checkpath.pl. > > But I'd also expect this to come through Luiz's QMP tree. I had this ready in my tree some time ago, but you commented on that version asking for errors descriptions and other things, so I didn't push it. But we have to set expectations here. My tree will eventually die, specially wrt new interfaces where I expect you to jump in ASAP. First because you have to be sure a new interface "conforms" to QAPI, and second (and more importantly) because it's time to pass this on to someone else (preferably you).