From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56210 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q6j8U-00081e-Ti
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 08:44:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Q6j8L-00056j-SE
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 08:43:59 -0400
Received: from hall.aurel32.net ([88.191.126.93]:51168)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Q6j8L-00056U-ML
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 08:43:53 -0400
Date: Mon, 4 Apr 2011 14:43:49 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] Fix non-portable format string in usb-ccid.c
Message-ID: <20110404124349.GA19002@volta.aurel32.net>
References: <1301892488-15114-1-git-send-email-david@gibson.dropbear.id.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1301892488-15114-1-git-send-email-david@gibson.dropbear.id.au>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-devel@nongnu.org

On Mon, Apr 04, 2011 at 02:48:08PM +1000, David Gibson wrote:
> At one point, usb-ccid.c attempts to use a %lX format specifier to print
> a uint64_t, which is only correct on some host platforms.  This patch
> corrects the statement to use the stdint specified PRIX64 constant instead.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>  hw/usb-ccid.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Thanks, applied.

> diff --git a/hw/usb-ccid.c b/hw/usb-ccid.c
> index 723b2e3..44156cc 100644
> --- a/hw/usb-ccid.c
> +++ b/hw/usb-ccid.c
> @@ -1199,7 +1199,7 @@ void ccid_card_card_error(CCIDCardState *card, uint64_t error)
>  
>      s->bmCommandStatus = COMMAND_STATUS_FAILED;
>      s->last_answer_error = error;
> -    DPRINTF(s, 1, "VSC_Error: %lX\n", s->last_answer_error);
> +    DPRINTF(s, 1, "VSC_Error: %" PRIX64 "\n", s->last_answer_error);
>      /* TODO: these error's should be more verbose and propogated to the guest.*/
>      /*
>       * We flush all pending answers on CardRemove message in ccid-card-passthru,
> -- 
> 1.7.1
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net