qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	Juan Quintela <quintela@redhat.com>,
	libvir-list@redhat.com, Stefan Hajnoczi <stefanha@gmail.com>,
	qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [libvirt] [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change
Date: Mon, 4 Apr 2011 14:16:39 +0100	[thread overview]
Message-ID: <20110404131639.GB13616@redhat.com> (raw)
In-Reply-To: <4D99C162.7060706@us.ibm.com>

On Mon, Apr 04, 2011 at 08:02:26AM -0500, Anthony Liguori wrote:
> On 04/04/2011 05:47 AM, Daniel P. Berrange wrote:
> >>I'm hoping libvirt's behavior can be made to just work rather than
> >>adding new features to QEMU.  But perhaps passing file descriptors is
> >>useful for more than just reopening host devices.  This would
> >>basically be a privilege separation model where the QEMU process isn't
> >>able to open files itself but can request libvirt to open them on its
> >>behalf.
> >It is rather frickin' annoying the way udev resets the ownership
> >when the media merely changes. If it isn't possible to stop udev
> >doing this, then i think the only practical thing is to use ACLs
> >instead of user/group ownership. We wanted to switch to ACLs in
> >libvirt for other reasons already, but it isn't quite as simple
> >as it sounds[1] so we've not done it just yet.
> 
> Isn't the root of the problem that you're not running a guest in the
> expected security context?

That doesn't really have any impact. If a desktop user is logged
in, udev may change the ownership to match that user, but if they
aren't, then udev may reset it to root:disk. Either way, QEMU
may loose permissions to the disk.

> How much of a leap would it be to spawn a guest with the credentials
> of the user that created/defined it?  Or better yet, to let the user
> be specified in the XML.

That's a completely independent RFE which won't fix this issue in
the general case.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

  reply	other threads:[~2011-04-04 13:39 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-29 19:04 [Qemu-devel] [PATCH v2 0/3] block: Correct size across CD-ROM media change Stefan Hajnoczi
2011-03-29 19:04 ` [Qemu-devel] [PATCH v2 1/3] trace: Trace bdrv_set_locked() Stefan Hajnoczi
2011-03-29 19:04 ` [Qemu-devel] [PATCH v2 2/3] block: Do not cache device size for removable media Stefan Hajnoczi
2011-03-29 19:04 ` [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change Stefan Hajnoczi
2011-03-31 10:05   ` [Qemu-devel] " Kevin Wolf
2011-04-01 14:09     ` Stefan Hajnoczi
2011-04-03 11:57   ` [Qemu-devel] " Stefan Hajnoczi
2011-04-03 13:12     ` Blue Swirl
2011-04-03 18:06       ` Stefan Hajnoczi
2011-04-04 10:47         ` [libvirt] " Daniel P. Berrange
2011-04-04 12:58           ` Stefan Hajnoczi
2011-04-04 13:02           ` Anthony Liguori
2011-04-04 13:16             ` Daniel P. Berrange [this message]
2011-04-04 14:19               ` Anthony Liguori
2011-04-04 14:26                 ` Daniel P. Berrange
2011-04-04 14:43                   ` Anthony Liguori
2011-04-04 16:38                     ` Blue Swirl
2011-04-04 13:22     ` Avi Kivity
2011-04-04 13:38       ` Anthony Liguori
2011-04-04 13:49         ` Avi Kivity
2011-04-04 15:09           ` Stefan Hajnoczi
2011-04-04 15:11             ` Avi Kivity
2011-04-05  6:41             ` Amit Shah
2011-04-05  7:48               ` Avi Kivity
2011-04-05  8:09                 ` Amit Shah
2011-04-05  9:00                   ` Avi Kivity
2011-04-05  9:12                     ` Amit Shah
2011-04-05  9:17                       ` Avi Kivity
2011-04-05  9:26                         ` Amit Shah
2011-04-06  8:07                         ` Amit Shah
2011-04-05  8:40               ` Stefan Hajnoczi
2011-04-05  8:58                 ` Amit Shah
2011-04-04 17:54         ` David Ahern
2011-04-05  5:33           ` Stefan Hajnoczi
2011-04-05  5:42             ` David Ahern
2011-04-05 12:41               ` Stefan Hajnoczi
2011-03-30  8:33 ` [Qemu-devel] [PATCH v2 0/3] block: Correct size across CD-ROM " Markus Armbruster
2011-03-30 10:06   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110404131639.GB13616@redhat.com \
    --to=berrange@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@gmail.com \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).