From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55381 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6mBw-0006zl-9u for qemu-devel@nongnu.org; Mon, 04 Apr 2011 11:59:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6mBl-00026h-1U for qemu-devel@nongnu.org; Mon, 04 Apr 2011 11:59:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26517) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6mBk-00026M-M1 for qemu-devel@nongnu.org; Mon, 04 Apr 2011 11:59:36 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p34FxYkr013548 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 4 Apr 2011 11:59:34 -0400 Date: Mon, 4 Apr 2011 18:59:18 +0300 From: "Michael S. Tsirkin" Message-ID: <20110404155917.GA13423@redhat.com> References: <1301930887-20705-1-git-send-email-avi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1301930887-20705-1-git-send-email-avi@redhat.com> Subject: [Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org On Mon, Apr 04, 2011 at 06:27:57PM +0300, Avi Kivity wrote: > Many PCI BARs that use the memory address space map a single MMIO region into > the entire BAR range. Introduce an API pci_register_bar_simple() for that use > case, and convert all users where this can be done trivially. > > This will reduce the work required to introduce a PCI memory API; it's also > a nice code reduction in its own right. This will save some code, so Acked-by: Michael S. Tsirkin I really hope the rest of devices will follow. > Avi Kivity (10): > pci: add pci_register_bar_simple() API > rtl8139: convert to pci_register_bar_simple() > cirrus-vga: convert to pci_register_bar_simple() > eepro100: convert to pci_register_bar_simple() > ich/ahci: convert to pci_register_bar_simple() > hda-intel: convert to pci_register_bar_simple() > hda-intel: convert to pci_register_bar_simple() (partial) > pcnet-pci: convert to pci_register_bar_simple() > usb-ohci: convert to pci_register_bar_simple() > wdt_i6300esb: convert to pci_register_bar_simple() > > hw/cirrus_vga.c | 13 ++----------- > hw/eepro100.c | 43 +++++++++++++------------------------------ > hw/ide/ahci.c | 9 --------- > hw/ide/ahci.h | 3 --- > hw/ide/ich.c | 3 +-- > hw/intel-hda.c | 11 +---------- > hw/lsi53c895a.c | 12 +----------- > hw/pci.c | 17 +++++++++++++++++ > hw/pci.h | 3 +++ > hw/pcnet-pci.c | 16 +--------------- > hw/rtl8139.c | 11 +---------- > hw/usb-ohci.c | 10 +--------- > hw/wdt_i6300esb.c | 42 +++++++++++++++--------------------------- > 13 files changed, 56 insertions(+), 137 deletions(-)