From: Aurelien Jarno <aurelien@aurel32.net>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] lan9118: Ignore write to MAC_VLAN1 register
Date: Mon, 4 Apr 2011 20:15:30 +0200 [thread overview]
Message-ID: <20110404181530.GC23034@volta.aurel32.net> (raw)
In-Reply-To: <1301406072-8649-1-git-send-email-anemo@mba.ocn.ne.jp>
On Tue, Mar 29, 2011 at 10:41:12PM +0900, Atsushi Nemoto wrote:
> Since kernel 2.6.38, smsc911x driver writes to VLAN1 registger.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> hw/lan9118.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/hw/lan9118.c b/hw/lan9118.c
> index af6949f..62aead3 100644
> --- a/hw/lan9118.c
> +++ b/hw/lan9118.c
> @@ -785,6 +785,8 @@ static void do_mac_write(lan9118_state *s, int reg, uint32_t val)
> case MAC_FLOW:
> s->mac_flow = val & 0xffff0000;
> break;
> + case MAC_VLAN1:
> + break; /* just ignore */
> default:
> hw_error("lan9118: Unimplemented MAC register write: %d = 0x%x\n",
> s->mac_cmd & 0xf, val);
Is it really safe ignoring write to this register? If yes, it's probably
a good idea to explain why in a comment. In any case, if supporting this
register is easy to do, it would be the best option.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2011-04-04 18:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 13:41 [Qemu-devel] [PATCH] lan9118: Ignore write to MAC_VLAN1 register Atsushi Nemoto
2011-04-04 18:15 ` Aurelien Jarno [this message]
2011-04-05 14:34 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110404181530.GC23034@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=anemo@mba.ocn.ne.jp \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).