From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51781 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q6piD-0000hE-C3
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 15:45:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Q6pi8-0006qX-8c
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 15:45:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61829)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Q6pi7-0006q3-Rr
	for qemu-devel@nongnu.org; Mon, 04 Apr 2011 15:45:16 -0400
Date: Mon, 4 Apr 2011 22:44:55 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple
Message-ID: <20110404194455.GA13721@redhat.com>
References: <1301930887-20705-1-git-send-email-avi@redhat.com>
	<20110404155917.GA13423@redhat.com>
	<4D99F061.1090208@codemonkey.ws> <4D99F34D.3060804@redhat.com>
	<BANLkTikwwVzrzkp5fxUqcpcPEE3m5hWsLA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <BANLkTikwwVzrzkp5fxUqcpcPEE3m5hWsLA@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

On Mon, Apr 04, 2011 at 08:02:23PM +0300, Blue Swirl wrote:
> On Mon, Apr 4, 2011 at 7:35 PM, Avi Kivity <avi@redhat.com> wrote:
> > On 04/04/2011 07:22 PM, Anthony Liguori wrote:
> >>
> >> On 04/04/2011 10:59 AM, Michael S. Tsirkin wrote:
> >>>
> >>> On Mon, Apr 04, 2011 at 06:27:57PM +0300, Avi Kivity wrote:
> >>>>
> >>>> Many PCI BARs that use the memory address space map a single MMIO =
region
> >>>> into
> >>>> the entire BAR range. =A0Introduce an API pci_register_bar_simple(=
) for
> >>>> that use
> >>>> case, and convert all users where this can be done trivially.
> >>>>
> >>>> This will reduce the work required to introduce a PCI memory API; =
it's
> >>>> also
> >>>> a nice code reduction in its own right.
> >>>
> >>> This will save some code, so
> >>> Acked-by: Michael S. Tsirkin<mst@redhat.com>
> >>>
> >>> I really hope the rest of devices will follow.
> >>
> >> How complete is this?
> >
> > I converted all devices which were easy to convert. =A0There may be o=
ne or two
> > more that can be converted with additional work (and perhaps with an
> > additional pic_bar_get_current_address() API, and a pci_bar_set_coale=
scing()
> > API). =A0The rest likely need to stick with the callback-based API.
>=20
> In my version which I sent earlier but didn't commit, also other BARs
> besides the first one and also tricky devices like VGA were handled.

Yes, I liked that patchset too. What happened to it?

> But I didn't commit it because I felt it was not going to right
> direction. I think the BARs should be specified in PCIDeviceInfo
> instead of adding more function calls. The same applies to this patch
> set.

Is that really that fundamental? What I do care about is
making pci.c track and register all device memory
so that we can finally implement pci bridge features
such as master abort handling and unmapped memory.

--=20
MST