From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42168 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6xfj-0000FH-PJ for qemu-devel@nongnu.org; Tue, 05 Apr 2011 00:15:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6xfh-0005zm-KZ for qemu-devel@nongnu.org; Tue, 05 Apr 2011 00:15:19 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:57121) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6xfh-0005z4-4h for qemu-devel@nongnu.org; Tue, 05 Apr 2011 00:15:17 -0400 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.31.245]) by e23smtp07.au.ibm.com (8.14.4/8.13.1) with ESMTP id p354F6UA021480 for ; Tue, 5 Apr 2011 14:15:06 +1000 Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p354F6vT2416868 for ; Tue, 5 Apr 2011 14:15:06 +1000 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p354F58j032179 for ; Tue, 5 Apr 2011 14:15:05 +1000 Date: Tue, 5 Apr 2011 14:14:59 +1000 From: David Gibson Message-ID: <20110405041459.GC466@yookeroo> References: <1301847684-8125-1-git-send-email-weil@mail.berlios.de> <4D99DDD0.5070107@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D99DDD0.5070107@suse.de> Subject: [Qemu-devel] Re: [PATCH] spapr_vscsi: Set uninitialized variable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: QEMU Developers On Mon, Apr 04, 2011 at 05:03:44PM +0200, Alexander Graf wrote: > On 04/03/2011 06:21 PM, Stefan Weil wrote: > >cppcheck reports this error: > > > >hw/spapr_vscsi.c:274: error: Uninitialized variable: rc > > > >If llen == 0, rc was indeed used without being initialized. > > > >Signed-off-by: Stefan Weil > >--- > > hw/spapr_vscsi.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > >diff --git a/hw/spapr_vscsi.c b/hw/spapr_vscsi.c > >index e142dae..9928334 100644 > >--- a/hw/spapr_vscsi.c > >+++ b/hw/spapr_vscsi.c > >@@ -255,7 +255,7 @@ static int vscsi_srp_direct_data(VSCSIState *s, vscsi_req *req, > > { > > struct srp_direct_buf *md = req->cur_desc; > > uint32_t llen; > >- int rc; > >+ int rc = 0; > > David, is this correct? Or would rc be -1 when !llen? I talked to Ben, who wrote this code - apparently his mail server blew up. This patch should be correct, AFAWCT. It's not totally clear what the right return value should be in thie case, or indeed that this case ever actually happens, but we think 0 is right. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson