[Qemu-devel] Re: [SeaBIOS] [PATCH V2 0/8] Add TPM support to SeaBIOS

[Kevin O'Connor <kevin@koconnor.net>]

On Mon, Apr 04, 2011 at 09:29:39PM -0400, Stefan Berger wrote:
> The following set of patches add TPM and Trusted Computing support to SeaBIOS.
> In particular the patches add:

Thanks Stefan.

In general, it looks okay to me.  Since this depends on a qemu change,
though, I'd like to see a qemu/kvm maintaner ack (or the dependent
changes committed in qemu) before committing to SeaBIOS.


Some minor nits:

Patch 4:
> +// TCG BIOS extensions
> +void tcpa_interrupt_handler16(struct bregs *regs);

This looks stale.

Patch 5:
> +#else
> +        
> +static u32
> +sha1_calc(const u8 *data, u32 length, u8 *hash)
> +{    
> +    return sha1(data, length, hash);

I'd prefer to avoid #ifdefs - it should be possible to do something
like:

sha1_calc(...) {
    if (CONFIG_TPM_FOR_SHA1)
         return tpm_sha1_calc(...);
    return sha1(...);
}


Finally, can you briefly describe what services that require TPM
support will now be available to end-users with this series?

-Kevin