From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39500 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q7260-00081g-TR
	for qemu-devel@nongnu.org; Tue, 05 Apr 2011 04:58:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Q725z-00077U-Op
	for qemu-devel@nongnu.org; Tue, 05 Apr 2011 04:58:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13922)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Q725z-00077A-GZ
	for qemu-devel@nongnu.org; Tue, 05 Apr 2011 04:58:43 -0400
Date: Tue, 5 Apr 2011 14:28:32 +0530
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after
	media change
Message-ID: <20110405085832.GA27661@amit-x200.redhat.com>
References: <1301425482-8722-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<1301425482-8722-4-git-send-email-stefanha@linux.vnet.ibm.com>
	<BANLkTik1LNYoJ6O2C+bPM80LBx8bGnr+uw@mail.gmail.com>
	<4D99C61E.3080600@redhat.com> <4D99C9ED.3020602@codemonkey.ws>
	<4D99CC74.9070703@redhat.com>
	<BANLkTimNCCFkRuPaJsmN6Q1ThV3-OP8MCA@mail.gmail.com>
	<20110405064120.GB2872@amit-x200.redhat.com>
	<BANLkTinJbCZnYbveDOBPkmYae6gCHMUP5g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BANLkTinJbCZnYbveDOBPkmYae6gCHMUP5g@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Juan Quintela <quintela@redhat.com>, libvir-list@redhat.com, qemu-devel@nongnu.org, Ryan Harper <ryanh@us.ibm.com>, Avi Kivity <avi@redhat.com>

On (Tue) 05 Apr 2011 [09:40:05], Stefan Hajnoczi wrote:
> > See http://www.spinics.net/lists/linux-scsi/msg51504.html
> 
> I don't think that patch updates the block inode size.  We'd need to
> call fs/block_dev.c:revalidate_disk() instead of directly calling
> cdi->disk->fops->revalidate_disk(cdi->disk).
> fs/block_dev.c:revalidate_disk() calls check_disk_size_change(), which
> will update the inode size.

Then the patch is buggy :-)  As Tejun also says in the thread, the
patch should be in the block layer, not sr.c.

(btw that patch does update /sys/block/sr0/size, so that part of
revalidation is done.)

		Amit