From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44881 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7X9Z-0003c0-Ka for qemu-devel@nongnu.org; Wed, 06 Apr 2011 14:08:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7X9Y-0008J2-8l for qemu-devel@nongnu.org; Wed, 06 Apr 2011 14:08:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7X9X-0008IO-Sw for qemu-devel@nongnu.org; Wed, 06 Apr 2011 14:08:28 -0400 Date: Wed, 6 Apr 2011 15:08:18 -0300 From: Luiz Capitulino Subject: Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command Message-ID: <20110406150818.56707b9b@doriath> In-Reply-To: <4D9CAAF9.7000509@codemonkey.ws> References: <4D74A8C9.2020408@cn.fujitsu.com> <4D74A974.6090509@cn.fujitsu.com> <20110404105949.GA30324@redhat.com> <4D99BF99.1040305@redhat.com> <4D99C22C.4070401@codemonkey.ws> <20110406144723.45333682@doriath> <4D9CAAF9.7000509@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Lai Jiangshan , Jiangshan , kvm@vger.kernel.org, qemu-devel@nongnu.org, Markus Armbruster , Avi Kivity On Wed, 06 Apr 2011 13:03:37 -0500 Anthony Liguori wrote: > On 04/06/2011 12:47 PM, Luiz Capitulino wrote: > > On Mon, 04 Apr 2011 08:05:48 -0500 > > Anthony Liguori wrote: > > > >> On 04/04/2011 07:54 AM, Avi Kivity wrote: > >>> On 04/04/2011 01:59 PM, Daniel P. Berrange wrote: > >>>> Interesting that with HMP you need to specify a single CPU index, but > >>>> with QMP it is injecting to all CPUs at once. Is there any compelling > >>>> reason why we'd ever need the ability to only inject to a single CPU > >>>> from an app developer POV ? > >>> When a PC has an NMI button, it is (I presume) connected to all CPUs' > >>> LINT1 pin, which is often configured as an NMI input. So the all-cpu > >>> variant corresponds to real hardware, while the single-cpu variant > >>> doesn't. > >>> > >>> wrt the app developer POV, the only use I'm aware of is that you can > >>> configure Windows to dump core when the NMI button is pressed and thus > >>> debug driver problems. It's likely more reliable when sent to all cpus. > >> It either needs to be removed from HMP or added to QMP. HMP shouldn't > >> have more features than QMP (even if those features are non-sensible). > > Is anyone against changing HMP behavior to send it to all CPUs? > > Makes sense to me. So, Lai, in order to get this merged could you please do the following: 1. Address checkpath.pl errors 2. Change the HMP to use this implementation, which send the NMI to all CPUs 3. Any other review comments I might be missing :) > > Regards, > > Anthony Liguori >