From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56491 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7ti8-00079h-12 for qemu-devel@nongnu.org; Thu, 07 Apr 2011 14:13:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7ti6-0001Qd-Ci for qemu-devel@nongnu.org; Thu, 07 Apr 2011 14:13:39 -0400 Received: from os.inf.tu-dresden.de ([141.76.48.99]:57938) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7ti6-0001QW-7E for qemu-devel@nongnu.org; Thu, 07 Apr 2011 14:13:38 -0400 Date: Thu, 7 Apr 2011 20:13:33 +0200 From: Adam Lackorzynski Subject: Re: [Qemu-devel] [PATCH] hw: improve multiboot module loading Message-ID: <20110407181333.GD5240@os.inf.tu-dresden.de> References: <312edea8efadfde52c4c6d267c924cf2.squirrel@humppa.name> <03A8D429-04D0-42D9-A664-7C52B3A4F812@suse.de> <7f0b8ad36b8e8d1828f0dfc1803c0da0.squirrel@humppa.name> <7CF0A1FA-F21A-4F3A-87D4-A62F1E4B21E6@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Ralf Ramsauer , Alexander Graf , QEMU Developers On Thu Apr 07, 2011 at 14:52:34 +0100, Stefan Hajnoczi wrote: > On Thu, Apr 7, 2011 at 1:56 PM, Ralf Ramsauer > wrote: > > On 07.04.2011, at 14:48, Stefan Hajnoczi wrote: > > > >> Out of curiousity, why are you trying to kill spaces at all? > >> > >> Why not just use a correct command-line to invoke QEMU? > >> > >> Stefan > > > > Well it took me 2 days to find out why -initrd "module1, module2" didn'= t work. If there's a space after the comma you'll always > > get the error message "Failed to get =A0image size". >=20 > How about improving the error message? I'll send a patch shortly fixing the message. =20 > > And if you want to pass a comma in a multiboot argument you've no way t= o do this. > > So -initrd"module1 settings=3Duse_foo,use_bar" won't work! >=20 > >From what I can tell your patch does not change this. It should be possible to put commas on the mb command line. Do we want to escape commas? Adam --=20 Adam adam@os.inf.tu-dresden.de Lackorzynski http://os.inf.tu-dresden.de/~adam/