From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41611 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q7uIY-0006Ut-1m
	for qemu-devel@nongnu.org; Thu, 07 Apr 2011 14:51:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1Q7uIW-0003eu-L8
	for qemu-devel@nongnu.org; Thu, 07 Apr 2011 14:51:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21715)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1Q7uIW-0003eh-7c
	for qemu-devel@nongnu.org; Thu, 07 Apr 2011 14:51:16 -0400
Date: Thu, 7 Apr 2011 21:51:08 +0300
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command
Message-ID: <20110407185108.GE7100@redhat.com>
References: <4D99C22C.4070401@codemonkey.ws> <20110406144723.45333682@doriath>
	<4D9CAAF9.7000509@codemonkey.ws> <20110406150818.56707b9b@doriath>
	<4D9CAE4B.7080305@siemens.com> <20110406160020.373cb5a2@doriath>
	<BANLkTinUfnq6b2u_bfdB_zc3z8dg=4gAbA@mail.gmail.com>
	<4D9CC044.2000705@codemonkey.ws>
	<BANLkTim4iP_YRjOCYH986BB=ec-dwcjfQA@mail.gmail.com>
	<4D9E0352.2050204@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D9E0352.2050204@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Peter Maydell <peter.maydell@linaro.org>, Lai Jiangshan <eag0628@gmail.com>, Jiangshan <laijs@cn.fujitsu.com>, kvm@vger.kernel.org, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Avi Kivity <avi@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

On Thu, Apr 07, 2011 at 01:32:50PM -0500, Anthony Liguori wrote:
> On 04/07/2011 01:10 PM, Peter Maydell wrote:
> >On 6 April 2011 20:34, Anthony Liguori<anthony@codemonkey.ws>  wrote:
> >>http://publib.boulder.ibm.com/infocenter/lnxinfo/v3r0m0/index.jsp?topic=/liaai/crashdump/liaaicrashdumpnmiipmi.htm
> >>
> >>If an OS is totally hosed (spinning with interrupts disabled), and NMI can
> >>be used to generate a crash dump.
> >>
> >>It's a debug feature and modelling it exactly the way we are probably makes
> >>sense for other architectures too.  The real semantics are basically force
> >>guest crash dump.
> >Ah, right. (There isn't really an equivalent to this on ARM since
> >we don't have a real NMI equivalent. So any implementation for ARM
> >qemu would be board dependent since you could wire a watchdog up to
> >any interrupt.)
> >
> >Should we try to pick a command name that says what it's supposed to
> >do rather than how it happens to be implemented on x86 ?
> 
> Yup, I was thinking the same thing after I sent the note above.  If
> we call it 'force-crash-dump', we can implement it as an NMI on
> target-i386 and potentially as something else on a different target.
> 
NMI does not have to generate crash dump on every guest we support.
Actually even for windows guest it does not generate one without
tweaking registry. For all I know there is a guest that checks mail when
NMI arrives. Lets give meaningful name, like inject-nmi, for nmi
injection command.

--
			Gleb.