From: Amit Shah <amit.shah@redhat.com>
To: qemu list <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 1/5] atapi: Allow GET_EVENT_STATUS_NOTIFICATION after media change
Date: Fri, 8 Apr 2011 12:55:40 +0530 [thread overview]
Message-ID: <20110408072540.GA7959@amit-x200.redhat.com> (raw)
In-Reply-To: <7dad199c525d4b2079658b090b210472f433e1c9.1302246567.git.amit.shah@redhat.com>
On (Fri) 08 Apr 2011 [12:45:15], Amit Shah wrote:
> After a media change, the only commands allowed from the guest were
> REQUEST_SENSE and INQUIRY. The guest may also issue
> GET_EVENT_STATUS_NOTIFICATION commands to get media
> changed notification.
>
> After this, the HSM violation messages from Linux guests aren't seen.
This isn't true -- the messages go only if TEST_UNIT_READY is also
added to the list. Removed this statement from local copy.
> diff --git a/hw/ide/core.c b/hw/ide/core.c
> index c11d457..327f703 100644
> --- a/hw/ide/core.c
> +++ b/hw/ide/core.c
> @@ -1105,10 +1105,11 @@ static void ide_atapi_cmd(IDEState *s)
> /* If there's a UNIT_ATTENTION condition pending, only
> REQUEST_SENSE and INQUIRY commands are allowed to complete. */
And updated this comment locally as well.
Amit
next prev parent reply other threads:[~2011-04-08 7:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 7:15 [Qemu-devel] [PATCH 0/5] atapi: Implement 'media' subcommand for GESN Amit Shah
2011-04-08 7:15 ` [Qemu-devel] [PATCH 1/5] atapi: Allow GET_EVENT_STATUS_NOTIFICATION after media change Amit Shah
2011-04-08 7:25 ` Amit Shah [this message]
2011-04-08 10:54 ` Markus Armbruster
2011-04-08 11:03 ` Kevin Wolf
2011-04-08 7:15 ` [Qemu-devel] [PATCH 2/5] ide: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own function Amit Shah
2011-04-08 7:15 ` [Qemu-devel] [PATCH 3/5] atapi: GESN: Spin off No Event Available handling into " Amit Shah
2011-04-08 13:31 ` [Qemu-devel] " Kevin Wolf
2011-04-09 10:36 ` Amit Shah
2011-04-11 8:51 ` Kevin Wolf
2011-04-08 7:15 ` [Qemu-devel] [PATCH 4/5] atapi: GESN: Add enums for commonly-used field types Amit Shah
2011-04-08 14:21 ` [Qemu-devel] " Kevin Wolf
2011-04-09 10:43 ` Amit Shah
2011-04-08 7:15 ` [Qemu-devel] [PATCH 5/5] atapi: Implement 'media' subcommand of GET_EVENT_STATUS_NOTIFICATION command Amit Shah
2011-04-08 16:17 ` [Qemu-devel] " Kevin Wolf
2011-04-09 13:57 ` Amit Shah
2011-04-08 7:21 ` [Qemu-devel] Re: [PATCH 0/5] atapi: Implement 'media' subcommand for GESN Paolo Bonzini
2011-04-08 9:39 ` [Qemu-devel] " Markus Armbruster
2011-04-11 6:18 ` Amit Shah
2011-04-11 13:46 ` Markus Armbruster
2011-04-12 4:22 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110408072540.GA7959@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).