From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51367 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q864l-0004HN-50
	for qemu-devel@nongnu.org; Fri, 08 Apr 2011 03:25:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Q864g-0007KY-IO
	for qemu-devel@nongnu.org; Fri, 08 Apr 2011 03:25:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17509)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Q864g-0007KI-9W
	for qemu-devel@nongnu.org; Fri, 08 Apr 2011 03:25:46 -0400
Date: Fri, 8 Apr 2011 12:55:40 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20110408072540.GA7959@amit-x200.redhat.com>
References: <cover.1302246567.git.amit.shah@redhat.com>
	<7dad199c525d4b2079658b090b210472f433e1c9.1302246567.git.amit.shah@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7dad199c525d4b2079658b090b210472f433e1c9.1302246567.git.amit.shah@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 1/5] atapi: Allow
 GET_EVENT_STATUS_NOTIFICATION after media change
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu list <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Juan Quintela <quintela@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Markus Armbruster <armbru@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On (Fri) 08 Apr 2011 [12:45:15], Amit Shah wrote:
> After a media change, the only commands allowed from the guest were
> REQUEST_SENSE and INQUIRY.  The guest may also issue
> GET_EVENT_STATUS_NOTIFICATION commands to get media
> changed notification.
> 
> After this, the HSM violation messages from Linux guests aren't seen.

This isn't true -- the messages go only if TEST_UNIT_READY is also
added to the list.  Removed this statement from local copy.

> diff --git a/hw/ide/core.c b/hw/ide/core.c
> index c11d457..327f703 100644
> --- a/hw/ide/core.c
> +++ b/hw/ide/core.c
> @@ -1105,10 +1105,11 @@ static void ide_atapi_cmd(IDEState *s)
>      /* If there's a UNIT_ATTENTION condition pending, only
>         REQUEST_SENSE and INQUIRY commands are allowed to complete. */

And updated this comment locally as well.

		Amit