From: Scott Wood <scottwood@freescale.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: avoid basename usage message
Date: Fri, 8 Apr 2011 15:20:38 -0500 [thread overview]
Message-ID: <20110408152038.677cb9da@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <4D9F6AE1.1030808@codemonkey.ws>
On Fri, 8 Apr 2011 15:06:57 -0500
Anthony Liguori <anthony@codemonkey.ws> wrote:
> On 04/08/2011 01:56 PM, Stefan Hajnoczi wrote:
> > On Fri, Apr 08, 2011 at 11:33:49AM -0500, Scott Wood wrote:
> >> diff --git a/configure b/configure
> >> index ae97e11..c5b85fe 100755
> >> --- a/configure
> >> +++ b/configure
> >> @@ -1233,7 +1233,8 @@ else
> >> fi
> >> sdl=no
> >> fi
> >> -if test -n "$cross_prefix"&& test "`basename $sdlconfig`" = sdl-config; then
> >> +if test -n "$cross_prefix" -a -n "$sdlconfig"&& \
> >> + test "`basename $sdlconfig`" = sdl-config; then
> > Instead of doing test -n "$sdlconfig" first with short-circuit
> > evaluation, I think would should do:
> >
> > test $(basename "$sdlconfig") = sdl-config
>
> $() is a bash-ism FYI.
See section 2.6.3 of
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html
And I've tested that it works in dash.
-Scott
prev parent reply other threads:[~2011-04-08 20:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 16:33 [Qemu-devel] [PATCH] configure: avoid basename usage message Scott Wood
2011-04-08 18:56 ` Stefan Hajnoczi
2011-04-08 19:15 ` [Qemu-devel] [PATCH v2] " Scott Wood
2011-04-09 11:19 ` [Qemu-devel] " Stefan Hajnoczi
2011-04-08 20:06 ` [Qemu-devel] [PATCH] " Anthony Liguori
2011-04-08 20:20 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110408152038.677cb9da@schlenkerla.am.freescale.net \
--to=scottwood@freescale.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).