From: Stefan Hajnoczi <stefanha@gmail.com>
To: Scott Wood <scottwood@freescale.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: avoid basename usage message
Date: Fri, 8 Apr 2011 19:56:02 +0100 [thread overview]
Message-ID: <20110408185602.GA15734@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <20110408163349.GA1212@schlenkerla.am.freescale.net>
On Fri, Apr 08, 2011 at 11:33:49AM -0500, Scott Wood wrote:
> diff --git a/configure b/configure
> index ae97e11..c5b85fe 100755
> --- a/configure
> +++ b/configure
> @@ -1233,7 +1233,8 @@ else
> fi
> sdl=no
> fi
> -if test -n "$cross_prefix" && test "`basename $sdlconfig`" = sdl-config; then
> +if test -n "$cross_prefix" -a -n "$sdlconfig" && \
> + test "`basename $sdlconfig`" = sdl-config; then
Instead of doing test -n "$sdlconfig" first with short-circuit
evaluation, I think would should do:
test $(basename "$sdlconfig") = sdl-config
Then you don't need to test sdlconfig because basename will produce an
empty string without error.
Stefan
next prev parent reply other threads:[~2011-04-08 18:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 16:33 [Qemu-devel] [PATCH] configure: avoid basename usage message Scott Wood
2011-04-08 18:56 ` Stefan Hajnoczi [this message]
2011-04-08 19:15 ` [Qemu-devel] [PATCH v2] " Scott Wood
2011-04-09 11:19 ` [Qemu-devel] " Stefan Hajnoczi
2011-04-08 20:06 ` [Qemu-devel] [PATCH] " Anthony Liguori
2011-04-08 20:20 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110408185602.GA15734@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).