From: Scott Wood <scottwood@freescale.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@gmail.com>
Subject: [Qemu-devel] [PATCH v2] configure: avoid basename usage message
Date: Fri, 8 Apr 2011 14:15:50 -0500 [thread overview]
Message-ID: <20110408191550.GA27007@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <20110408185602.GA15734@stefanha-thinkpad.localdomain>
basename prints a missing-argument error when sdlconfig is empty
and we're cross-compiling.
Signed-off-by: Scott Wood <scottwood@freescale.com>
---
v2: quote the input to basename rather than introduce an extra test,
as suggested by Stefan.
configure | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index ae97e11..2bb3faa 100755
--- a/configure
+++ b/configure
@@ -1233,7 +1233,7 @@ else
fi
sdl=no
fi
-if test -n "$cross_prefix" && test "`basename $sdlconfig`" = sdl-config; then
+if test -n "$cross_prefix" && test "$(basename "$sdlconfig")" = sdl-config; then
echo warning: using "\"$sdlconfig\"" to detect cross-compiled sdl >&2
fi
--
1.7.1
next prev parent reply other threads:[~2011-04-08 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 16:33 [Qemu-devel] [PATCH] configure: avoid basename usage message Scott Wood
2011-04-08 18:56 ` Stefan Hajnoczi
2011-04-08 19:15 ` Scott Wood [this message]
2011-04-09 11:19 ` [Qemu-devel] Re: [PATCH v2] " Stefan Hajnoczi
2011-04-08 20:06 ` [Qemu-devel] [PATCH] " Anthony Liguori
2011-04-08 20:20 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110408191550.GA27007@schlenkerla.am.freescale.net \
--to=scottwood@freescale.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).