From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53343 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q8H9w-0000Na-Dc for qemu-devel@nongnu.org; Fri, 08 Apr 2011 15:15:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q8H9v-00078e-BS for qemu-devel@nongnu.org; Fri, 08 Apr 2011 15:15:56 -0400 Received: from ch1ehsobe004.messaging.microsoft.com ([216.32.181.184]:18054 helo=ch1outboundpool.messaging.microsoft.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q8H9v-000786-5Q for qemu-devel@nongnu.org; Fri, 08 Apr 2011 15:15:55 -0400 Date: Fri, 8 Apr 2011 14:15:50 -0500 From: Scott Wood Message-ID: <20110408191550.GA27007@schlenkerla.am.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20110408185602.GA15734@stefanha-thinkpad.localdomain> Subject: [Qemu-devel] [PATCH v2] configure: avoid basename usage message List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi basename prints a missing-argument error when sdlconfig is empty and we're cross-compiling. Signed-off-by: Scott Wood --- v2: quote the input to basename rather than introduce an extra test, as suggested by Stefan. configure | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index ae97e11..2bb3faa 100755 --- a/configure +++ b/configure @@ -1233,7 +1233,7 @@ else fi sdl=no fi -if test -n "$cross_prefix" && test "`basename $sdlconfig`" = sdl-config; then +if test -n "$cross_prefix" && test "$(basename "$sdlconfig")" = sdl-config; then echo warning: using "\"$sdlconfig\"" to detect cross-compiled sdl >&2 fi -- 1.7.1