From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58757 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q8gmU-0004lu-HX
	for qemu-devel@nongnu.org; Sat, 09 Apr 2011 18:37:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Q8gmT-000292-2y
	for qemu-devel@nongnu.org; Sat, 09 Apr 2011 18:37:26 -0400
Received: from hall.aurel32.net ([88.191.126.93]:47273)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Q8gmS-00028l-TD
	for qemu-devel@nongnu.org; Sat, 09 Apr 2011 18:37:25 -0400
Date: Sun, 10 Apr 2011 00:37:23 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 2/3] exec: Remove a type cast which is no
	longer needed
Message-ID: <20110409223722.GE11487@volta.aurel32.net>
References: <1301170017-12368-1-git-send-email-weil@mail.berlios.de>
	<1301170017-12368-2-git-send-email-weil@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1301170017-12368-2-git-send-email-weil@mail.berlios.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>

On Sat, Mar 26, 2011 at 09:06:56PM +0100, Stefan Weil wrote:
> All other type casts in calls of cpu_physical_memory_write are
> used by hardware emulations and will be fixed by separate patches.
> 
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  exec.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/exec.c b/exec.c
> index 964ce31..d7afe30 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -4249,7 +4249,7 @@ void stw_phys(target_phys_addr_t addr, uint32_t val)
>  void stq_phys(target_phys_addr_t addr, uint64_t val)
>  {
>      val = tswap64(val);
> -    cpu_physical_memory_write(addr, (const uint8_t *)&val, 8);
> +    cpu_physical_memory_write(addr, &val, 8);
>  }
>  
>  /* virtual memory access for debug (includes writing to ROM) */
> -- 
> 1.7.2.5
> 

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net