From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36862 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q8t83-00056m-ML
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 07:48:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1Q8t7w-0000Lw-5P
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 07:48:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13316)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1Q8t7v-0000Lf-L9
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 07:48:24 -0400
Date: Sun, 10 Apr 2011 14:48:02 +0300
From: Alon Levy <alevy@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] qxl: allow QXL_IO_LOG also in vga
Message-ID: <20110410114802.GC6329@playa.tlv.redhat.com>
References: <1302431166-17771-1-git-send-email-alevy@redhat.com>
	<1302431166-17771-5-git-send-email-alevy@redhat.com>
	<201104102137.13005.bradh@frogmouth.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201104102137.13005.bradh@frogmouth.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Brad Hards <bradh@frogmouth.net>
Cc: qemu-devel@nongnu.org

On Sun, Apr 10, 2011 at 09:37:12PM +1000, Brad Hards wrote:
> On Sun, 10 Apr 2011 08:26:06 pm Alon Levy wrote:
> > -        if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT)
> > +        if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT
> > +            || (io_port == QXL_IO_LOG))
> I think this might look better with consistent use of brackets.
> 
> Low priority, for your consideration.
> 
Thanks, I'll fix before sending final version (unless this is the final
version - but that never happens).

> Brad