From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39144 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q8tnf-0007c9-Ap
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 08:31:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Q8tne-0000TF-1W
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 08:31:31 -0400
Received: from hall.aurel32.net ([88.191.126.93]:33267)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Q8tnd-0000SS-TD
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 08:31:30 -0400
Date: Sun, 10 Apr 2011 14:31:19 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20110410123119.GA4551@volta.aurel32.net>
References: <4DA15DCE.3000206@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <4DA15DCE.3000206@web.de>
Subject: [Qemu-devel] Re: [PATCH] musicpal: Fix registration of MMIO-less
	sysbus devices
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel <qemu-devel@nongnu.org>

On Sun, Apr 10, 2011 at 09:35:42AM +0200, Jan Kiszka wrote:
> The proper way to signal that a sysbus devices need no MMIO region is to
> pass -1 to sysbus_create_simple.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
> ---
>  hw/musicpal.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Thanks, applied.

> diff --git a/hw/musicpal.c b/hw/musicpal.c
> index d98aa8d..52b2931 100644
> --- a/hw/musicpal.c
> +++ b/hw/musicpal.c
> @@ -1597,11 +1597,11 @@ static void musicpal_init(ram_addr_t ram_size,
>      musicpal_misc_init();
>  
>      dev = sysbus_create_simple("musicpal_gpio", MP_GPIO_BASE, pic[MP_GPIO_IRQ]);
> -    i2c_dev = sysbus_create_simple("gpio_i2c", 0, NULL);
> +    i2c_dev = sysbus_create_simple("gpio_i2c", -1, NULL);
>      i2c = (i2c_bus *)qdev_get_child_bus(i2c_dev, "i2c");
>  
>      lcd_dev = sysbus_create_simple("musicpal_lcd", MP_LCD_BASE, NULL);
> -    key_dev = sysbus_create_simple("musicpal_key", 0, NULL);
> +    key_dev = sysbus_create_simple("musicpal_key", -1, NULL);
>  
>      /* I2C read data */
>      qdev_connect_gpio_out(i2c_dev, 0,
> -- 
> 1.7.1
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net