From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49444 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q90Ge-0005In-F0
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 15:25:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Q90Gd-0002oF-5m
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 15:25:52 -0400
Received: from hall.aurel32.net ([88.191.126.93]:37301)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Q90Gc-0002oA-VV
	for qemu-devel@nongnu.org; Sun, 10 Apr 2011 15:25:51 -0400
Date: Sun, 10 Apr 2011 21:25:49 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 02/15] s390x: set alignment for long to 8
Message-ID: <20110410192549.GD4551@volta.aurel32.net>
References: <1301927544-32767-1-git-send-email-agraf@suse.de>
	<1301927544-32767-3-git-send-email-agraf@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1301927544-32767-3-git-send-email-agraf@suse.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: peter.maydell@linaro.org, QEMU-devel Developers <qemu-devel@nongnu.org>, Richard Henderson <rth@twiddle.net>

On Mon, Apr 04, 2011 at 04:32:11PM +0200, Alexander Graf wrote:
> The alignment for longs on s390x is 8. That's the only place where it differs
> from the default alignments found in configure already. The example alignment
> program from Laurent printed the following on a real s390x:
> 
>   alignof(short) 2
>   alignof(int) 4
>   alignof(long) 8
>   alignof(long long) 8
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  configure |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Thanks, applied.

> diff --git a/configure b/configure
> index faaed60..1e068e6 100755
> --- a/configure
> +++ b/configure
> @@ -3182,6 +3182,7 @@ case "$target_arch2" in
>    s390x)
>      target_nptl="yes"
>      target_phys_bits=64
> +    target_long_alignment=8
>    ;;
>    *)
>      echo "Unsupported target CPU"
> -- 
> 1.6.0.2
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net